-
Notifications
You must be signed in to change notification settings - Fork 555
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fly-away Follow-Me fix #1145
Fly-away Follow-Me fix #1145
Conversation
Filter out spurious location updates using average speed (vs. arbitrary speed limit). Fixes DroidPlanner#1128
This solves the same issue as #1130, but uses average speed instead of an arbitrary 15 m/s (or other) speed limit. |
@kellyschrock is the constant factor used to calculate the upper limit for the current speed an arbitrary value? |
I originally used a much lower factor (1.25), and found that it took a very long time for the UAV to start following. In my experience, location jumping is only likely to happen very soon after starting Follow-Me mode (while the device isn't moving very fast if at all). In that case, anything less than a 4x increase in speed seems reasonable. |
So from your testing, is it behaving as expected with the changes in this PR. |
Yes, it is. I did several tests this morning, and it's behaving as expected. On Tue, Oct 7, 2014 at 12:42 PM, Fredia Huya-Kouadio <
|
Sounds good! The factor would probably need more testing with additional transportation means, but it's a great first step! |
Filter out spurious location updates using average speed (vs. arbitrary speed limit). Fixes DroidPlanner#1128
Filter out spurious location updates using average speed (vs. arbitrary speed limit). Fixes DroidPlanner#1128
Filter out spurious location updates using average speed (vs. arbitrary speed limit). Fixes DroidPlanner#1128
Filter out spurious location updates using average speed (vs. arbitrary speed limit). Fixes DroidPlanner#1128
Filter out spurious location updates using average speed (vs. arbitrary speed limit). Fixes DroidPlanner#1128
Filter out spurious location updates using average speed (vs. arbitrary speed limit). Fixes DroidPlanner#1128
Filter out spurious location updates using average speed (vs. arbitrary speed limit). Fixes DroidPlanner#1128
Filter out spurious location updates using average speed (vs. arbitrary speed limit). Fixes DroidPlanner#1128
Will do. Sorry about all the commits, I had difficulty pushing to my fork. On Tue, Oct 7, 2014 at 12:58 PM, Fredia Huya-Kouadio <
|
You can always debase your branch and summarize the commits, and later do a
|
Filter out spurious location updates using average speed
(vs. arbitrary speed limit).
Fixes #1128