Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BaiduMap v4.0.0 support - For merging #1788

Merged
merged 1 commit into from
Aug 12, 2016

Conversation

droneboost
Copy link
Contributor

@ne0fhyk

I've squashed commit histories in this PR, would you please check and approve merge?

Thanks.

@m4gr3d
Copy link
Member

m4gr3d commented Aug 12, 2016

@droneboost looks good to go!

@m4gr3d m4gr3d merged commit 6d709aa into DroidPlanner:develop Aug 12, 2016
@droneboost
Copy link
Contributor Author

@ne0fhyk, thanks for merging.

@Linjieqiang
Copy link

@Tanson Thanks.Also thanks @droneboost code for baidu map.

@droneboost
Copy link
Contributor Author

@Linjieqiang, Thanks! We are looking forward to see your PR with more new feature for CN maps. Let's make Tower a better GCS App together.

@droneboost droneboost deleted the develop_upstream branch August 16, 2016 05:05
@m4gr3d
Copy link
Member

m4gr3d commented Aug 21, 2016

@droneboost I'm preparing to release the first beta for version 4.0. How do I go about updating the baidu map developer key?

@droneboost
Copy link
Contributor Author

@ne0fhyk , do you have a Baidu developer account? If don't have, please register an account on following links:

https://passport.baidu.com/v2/?reg&tpl=newdev&u=http://developer.baidu.com/

@m4gr3d
Copy link
Member

m4gr3d commented Sep 5, 2016

@droneboost I'm unable to register for an account since it requires a chinese mobile phone number. Any suggestions?

@droneboost
Copy link
Contributor Author

droneboost commented Sep 5, 2016

@ne0fhyk , seems Chinese mobile phone number is a prerequisite of BD developer account, for the time being, I think I can apply a map API key for you for testing, if you share your android SDK sha1 signature on your build machine to me, please check this page: http://lbsyun.baidu.com/index.php?title=androidsdk/guide/key

@m4gr3d
Copy link
Member

m4gr3d commented Sep 6, 2016

@droneboost sounds good. Can you send me your email address, so I can email you the sha1 fingerprint. You can find my email address on my github profile. I'm unable to find your email on github though.

In addition, am I able to release the app with the map API key you will send?

@droneboost
Copy link
Contributor Author

droneboost commented Sep 6, 2016

@ne0fhyk , my email : [email protected], I've sent you an email.

In addition, am I able to release the app with the map API key you will send?

Sure! Before you are able to get your own Baidu developer account, I'm glad to maintain the baidu map API key for Tower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants