Fixes issues with Droneshare Uploader service

[m4gr3d]

This PR fixes a couple of issues with the Droneshare uploader service:

• Network connectivity detection: the uploader service was listening for network connectivity changes, but it didn't discriminate between connectivity gain/loss and connectivity type updates. As documented @ http://developer.android.com/training/monitoring-device-state/connectivity-monitoring.html#MonitorChanges, changes to a device's connectivity can be very frequent, resulting in numerous false restarts of the service.
  The update in the PR uses the techniques advocated @ http://developer.android.com/training/monitoring-device-state/manifest-receivers.html#ToggleReceivers to restrict the Droneshare uploader service restarts to actual connectiivty gain/loss events.
• Fixed improper generation, and handling of the notifications for the Droneshare uploader service.

[m4gr3d]

@geeksville I entered a bogus username and password for droneshare in order to test the uploader service, and it was successfully able to upload the log files. Is that expected, or by design?

[squilter]

I think that it just created an account with that login info. It should reject if you retry that same bogus username with a different bogus password.

[geeksville]

@ne0fhyk - yes. If you pick a username that is not in use it will create that user.

[geeksville]

@ne0fhyk - thanks for your great fixes! One question: Why did you want preferences keys to be localizable? It seems to me those strings are opaque and therefore best excluded from strings.xml.

[arthurbenemann]

@kevin: It is because then they stay linked by the AS and eclipse tools,
making easy to navigate between the files.
On Jul 19, 2014 12:59 PM, "Kevin Hester" [email protected] wrote:

@ne0fhyk https://github.com/ne0fhyk - thanks for your great fixes! One
question: Why did you want preferences keys to be localizable? It seems to
me those strings are opaque and therefore best excluded from strings.xml.

—
Reply to this email directly or view it on GitHub
#920 (comment)
.

[m4gr3d]

@geeksville it also allows to have a constant reference to the preference keys strings that is accessible from code and from the preference XML file. This way if any keys need to be updated, only one value has to be changed.
The set of keys is also stored in its own file, preference_keys.xml, instead of the strings.xml file, with a comment forbidding localization of that file.

[m4gr3d]

@arthurbenemann @squilter can one (or both) of you review the PR, and gives me a thumb up (or down). I'd like to merge it, as I'm having a lot of issues with the bugs it fixes when used with android wear.

[arthurbenemann]

@squilter Can you review it, so we have at least one peer review.

@ne0fhyk I'm sorry for the slow down on review/ merge of pull. It's because I'm on vacation to the end of this week.

[squilter]

@ne0fhyk Seems to work as expected.

There were three localization FIXMEs.

Are passwords really stored in plaintext?

[m4gr3d]

@geeksville how is authentication handled on droneshare? Would it be possible to send the username/password credentials pair, and receive a unique token from droneshare that can be used for further/future authentication?
As @squilter is pointing out, the credentials should not be stored in plaintext.

[m4gr3d]

@squilter I suggest we create another issue for the localization, and the credentials handling. This fix is only targeting the frequency of uploads, and the notification dispatching from the uploader service.

[m4gr3d]

@arthurbenemann no problem, enjoy the break!

[m4gr3d]

@squilter the localization fixmes were taking care of.
@arthurbenemann since this PR was peer reviewed, I'll go ahead, and merge it. Feel free to revert it if you find any issue.

[arthurbenemann]

@ne0fhyk Thanks for the merge.