-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OpenJdk 21 #229
OpenJdk 21 #229
Conversation
WalkthroughThe recent update involves upgrading the Java Development Kit (JDK) version from 17 to 21 in the project's GitHub Actions workflows, ensuring the build process utilizes the latest JDK features and security updates. Additionally, the project's codebase has been updated to leverage the latest JavaFX APIs, specifically by importing Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files ignored due to path filters (3)
owlplug-controls/pom.xml
is excluded by:!**/*.xml
owlplug-host/pom.xml
is excluded by:!**/*.xml
pom.xml
is excluded by:!**/*.xml
Files selected for processing (3)
- .github/workflows/dev.yml (1 hunks)
- .github/workflows/main.yml (8 hunks)
- owlplug-client/src/main/java/com/owlplug/core/tasks/AbstractTask.java (2 hunks)
Additional comments: 12
.github/workflows/dev.yml (2)
- 14-14: The change in the JDK setup name from "Set up JDK 17" to "Set up JDK 21" correctly reflects the updated JDK version.
- 18-18: The
java-version
is updated to21
to match the new JDK version. Ensure that all Java code in the project is compatible with JDK 21 to avoid build or runtime issues.owlplug-client/src/main/java/com/owlplug/core/tasks/AbstractTask.java (2)
- 23-23: The import of
javafx.concurrent.Worker
is correctly added to useWorker.State
in thetoString
method. This change enhances code clarity by explicitly specifying theState
enum's source.- 103-103: Updating the comparison from
State.FAILED
toWorker.State.FAILED
in thetoString
method improves the maintainability and clarity of the code by explicitly referencing theWorker
class'sState
enumeration. This change is consistent with best practices for readability and maintainability..github/workflows/main.yml (8)
- 24-28: The JDK version is updated to 21 in the
build-host-win
job. This change is correctly applied, ensuring the workflow uses the latest JDK version for the Windows build environment.- 53-57: The JDK version is updated to 21 in the
build-host-osx
job. This ensures the macOS build environment is using the latest JDK version, aligning with the project's upgrade to JDK 21.- 84-88: The JDK version is updated to 21 in the
build-host-linux
job. This change correctly updates the Linux build environment to use the latest JDK version.- 116-120: The JDK version is updated to 21 in the
build-jar
job. This ensures that the Java artifacts are built using the latest JDK version, aligning with the project's upgrade to JDK 21.- 162-166: The JDK version is updated to 21 in the
package-win
job. This change ensures that the Windows packaging process uses the latest JDK version.- 188-192: The JDK version is updated to 21 in the
package-osx
job. This ensures that the macOS packaging process uses the latest JDK version.- 213-217: The JDK version is updated to 21 in the
package-linux-deb
job. This change ensures that the Debian package creation process uses the latest JDK version.- 238-242: The JDK version is updated to 21 in the
package-linux-appimage
job. This ensures that the AppImage creation process uses the latest JDK version, aligning with the project's upgrade to JDK 21.
Summary by CodeRabbit