Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jm/add icon color prop to button #111

Merged
merged 3 commits into from
Dec 19, 2023
Merged

Conversation

jamesducky
Copy link
Contributor

Summary of changes included in this PR

  • Adds a icon-color prop to plmg-button to override default behavior. If no prop provided everything should stay as is.

Reviewer checklist:

  • Tests for
    • accessibility
    • rendered HTML (spec)
  • Storybook stories for all variants
  • JSDoc documentation for component
  • Update Example app (React, ...)

Copy link

github-actions bot commented Dec 19, 2023

Visit the preview URL for this PR (updated for commit 7eb7692):

https://test-auth-d13f2--pr111-jm-addiconcolorpropt-wyeqmbrm.web.app

(expires Tue, 26 Dec 2023 15:15:36 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: a53008a19f55b467e8188c6bc46d7c436559b643

@TanguyDucky TanguyDucky self-requested a review December 19, 2023 15:27
Copy link
Contributor

@TanguyDucky TanguyDucky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected, good job :-)
image

@TanguyDucky TanguyDucky merged commit 84cc3c1 into main Dec 19, 2023
6 checks passed
@TanguyDucky TanguyDucky deleted the JM/addIconColorPropToButton branch December 19, 2023 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants