Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Present errors gracefully, with actionable info #40

Open
dleehr opened this issue May 31, 2019 · 0 comments
Open

Present errors gracefully, with actionable info #40

dleehr opened this issue May 31, 2019 · 0 comments

Comments

@dleehr
Copy link
Member

dleehr commented May 31, 2019 •
edited
Loading

Related to Duke-GCB/D4S2#206, but I find that most API error codes are not handled gracefully by datadelivery-ui

  • Visiting a delivery that is not found (e.g. https://datadelivery.genome.duke.edu/deliveries/phony-id) results in an empty page, and some JS errors in the console. This should be a helpful 404-style page
  • detail message strings provided by the API are represented as [Object object] in the Ember Data error response, suggesting they're not being deserialized correctly. This is difficult to see in the current state, since the errors aren't really being displayed
dleehr added a commit that referenced this issue Jun 5, 2019
@dleehr
Adds duke-ds-project-size component
07e2a4f 
- Calls getSummary() on instantiation to fetch project summary
- Does not handle errors - see #40
- Shows loading indicator while summary is fetched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dleehr