Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add quote reply #252

Merged
merged 5 commits into from
Sep 26, 2023
Merged

feat: add quote reply #252

merged 5 commits into from
Sep 26, 2023

Conversation

Deva-1903
Copy link
Contributor

Fixes #167 -- Quote reply

**My PR closes #167 **

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Added quote reply button in drop down and handler function to handle quote reply
  • Added drop-down list to receiver's message box with only copy and quote reply option.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

@vercel
Copy link

vercel bot commented Feb 12, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@Deva-1903
Copy link
Contributor Author

Let me know if anything needs to be changed. Thank you.

@Dun-sin Dun-sin changed the title feature: Added quote reply feat: add quote reply Feb 13, 2023
Dun-sin
Dun-sin previously approved these changes Feb 13, 2023
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, just one problem, it has to be also implemented in the backend. Else this whole feature is useless. So here's what's going to happen, i'm going to leave this PR, please don't delete this branch, so i can create a new issue for the backend part of this, assuming you don't know anything about the backend.

Thanks for the PR.

@Dun-sin Dun-sin merged commit 54550e1 into Dun-sin:main Sep 26, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] add quote reply
2 participants