-
Notifications
You must be signed in to change notification settings - Fork 367
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: email validation middleware added (#381) #387
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel. @Dun-sin first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Compliance Checks Passed!
Please let me know if I did anything wrong, I have tried sticking to the rules strictly |
There's a new rule added in case you missed it, it's fine it was added today. It says to show a screen recording of your working software if you worked on the backend |
β¦ into email-validator
β¦ into email-validator
|
yeah just a second im uploading the recording on a cloud to embed it here |
tydlye.mp4So what I've done to show functionality is that I've used Postman to send the POST and DELETE requests to the server where the emailValidator is required. I've sent JSONs with both valid and invalid emails to show that the validation works as intended. (PS: The final commit introduced the changes that were made in the main repository before I re-synced my fork, I pulled those changes and then committed again) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.
Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. ππ½hereππ½
Thanks! I've already starred the project. Thanks for giving me the opportunity:) |
you are welcome |
Fixes Issue
My PR closes #381
π¨βπ» Changes proposed(What did you do ?)
I have added a custom middleware for email validation called "emailValidator" and have used it in the required request handlers. This aims to prevent duplication and is a modular approach to handle email-validation.
βοΈ Check List (Check all the applicable boxes)
Note to reviewers
I believe the code should work fine just as before since I personally tested it, but if any issue arises, please let me know, I'll earnestly fix them.
π· Screenshots