Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Custom 404 Page #498

Merged
merged 2 commits into from
Oct 20, 2023
Merged

feat: Add Custom 404 Page #498

merged 2 commits into from
Oct 20, 2023

Conversation

devXprite
Copy link
Contributor

@devXprite devXprite commented Oct 20, 2023

Fixes Issue

closes #486

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

Add Custom 404 Page

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

πŸ“· Screenshots

276854484-9dd8f293-7eed-4330-ba02-aeb152f4dab8

@vercel
Copy link

vercel bot commented Oct 20, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@vercel
Copy link

vercel bot commented Oct 20, 2023

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 20, 2023 11:27am

@Dun-sin
Copy link
Owner

Dun-sin commented Oct 20, 2023

Doesn't look good in mobile
Screenshot_2023-10-20-12-08-20-012_com.brave.browser.jpg

@devXprite
Copy link
Contributor Author

I fixed this bug in latest commit. Does it look good now?

localhost_5173_foundusers

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit cc1c668 into Dun-sin:main Oct 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Add Custom 404 page
2 participants