Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improved encryption #569

Merged
merged 6 commits into from
Nov 11, 2023
Merged

feat: improved encryption #569

merged 6 commits into from
Nov 11, 2023

Conversation

Aryakoste
Copy link
Contributor

Fixes Issue #550

**My PR closes #550

👨‍💻 Changes proposed(What did you do ?)

  1. Created an fully end to end encryption system.
  2. Each chat will have its unique private and public key and will be cleared only on closing the chat.

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

@vercel Vercel
Copy link

vercel bot commented Nov 9, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @Dun-sin on Vercel.

@Dun-sin first needs to authorize it.

Dun-sin
Dun-sin requested changes Nov 10, 2023
View reviewed changes
client/src/components/Chat.jsx Outdated Show resolved Hide resolved
client/src/components/Chat.jsx Outdated Show resolved Hide resolved
client/src/components/Chat.jsx Outdated Show resolved Hide resolved
client/src/components/Chat.jsx Outdated Show resolved Hide resolved
client/src/components/Chat.jsx Outdated Show resolved Hide resolved
client/src/context/reducers/chatReducer.js Show resolved Hide resolved
client/src/lib/chatSocket.js Outdated Show resolved Hide resolved
server/.env_sample Outdated Show resolved Hide resolved
Dun-sin
Dun-sin reviewed Nov 11, 2023
View reviewed changes
client/src/components/Chat.jsx
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this check for notifications?

client/src/context/reducers/chatReducer.js Show resolved Hide resolved
Dun-sin
Dun-sin previously approved these changes Nov 11, 2023
View reviewed changes
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did wonderful with this, thank you

client/src/components/Chat.jsx Show resolved Hide resolved
@Dun-sin Dun-sin merged commit 910e5da into Dun-sin:main Nov 11, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dun-sin Dun-sin Dun-sin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Improve on encryption
2 participants
@Aryakoste @Dun-sin