Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: can't read bad word warning text in light mode #627

Merged
merged 4 commits into from
Jul 18, 2024
Merged

fix: can't read bad word warning text in light mode #627

merged 4 commits into from
Jul 18, 2024

Conversation

TysonThurman
Copy link
Contributor

@TysonThurman TysonThurman commented Jul 15, 2024 •
edited
Loading

Fixes Issue

My PR closes #622

👨‍💻 Changes proposed(What did you do ?)

  • Added the proper dark mode tailwind class to change the warning text to black so it's readable.

✔️ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

📷 Screenshots

badword_lightmode badword_darkmode

@vercel Vercel
Copy link

vercel bot commented Jul 15, 2024

Someone is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Dun-sin
Dun-sin requested changes Jul 16, 2024
View reviewed changes
client/package-lock.json Outdated Show resolved Hide resolved
client/src/components/Chat.jsx Outdated Show resolved Hide resolved
client/src/components/Chat.jsx Outdated Show resolved Hide resolved
client/src/index.css Outdated Show resolved Hide resolved
@TysonThurman
Copy link
Contributor Author

Okay sorry about that , I will work on these changes

@Dun-sin
Copy link
Owner

Dun-sin commented Jul 16, 2024

Okay sorry about that , I will work on these changes

No need for sorry, open source is all about learning💪🏽

@TysonThurman
Copy link
Contributor Author

I believe I have properly addressed the issue and made the changes you requested. I hit "re-request review". I hope that is the proper action. Please let me know if I missed anything. Thanks so much for letting me contribute to the project!

@vercel Vercel
Copy link

vercel bot commented Jul 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
whisper ❌ Failed (Inspect) Jul 17, 2024 2:30pm
whisper-b2p2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 17, 2024 2:30pm

Dun-sin
Dun-sin approved these changes Jul 18, 2024
View reviewed changes
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project to your friends and joining the community discord server if you haven't for more resources and opportunities to connect with others. 👉🏽here👈🏽

@Dun-sin Dun-sin merged commit c6f0687 into Dun-sin:main Jul 18, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dun-sin Dun-sin Dun-sin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] can't read warning text in light mode
2 participants
@TysonThurman @Dun-sin