Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Copying chat not work #629

Merged
merged 8 commits into from
Aug 7, 2024
Merged

fix: Copying chat not work #629

merged 8 commits into from
Aug 7, 2024

Conversation

Golu7667
Copy link
Contributor

Fixes Issue

My PR closes #628

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

Send cryptoKey and importedPrivateKey to chatHelper. The message is encrypted and then decrypted using the decryptMessage function with the key (cryptoKey, importedPrivateKey). After decryption, copying text works correctly.

βœ”οΈ Check List (Check all the applicable boxes)

  • [1] My code follows the code style of this project.
  • [2] This PR does not contain plagiarized content.
  • [3] The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

whispercopyworking

Copy link

vercel bot commented Jul 19, 2024

@Golu7667 is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@Golu7667
Copy link
Contributor Author

@Dunsin review my pr and merge this

@Dun-sin
Copy link
Owner

Dun-sin commented Jul 20, 2024

@Dunsin review my pr and merge this

keep in mind in the future you don't need to comment back on the Issue, you can after 5 days, it's not my first rodeo, so I see your PR and will definitely do what's needed to be done. It will just cause unnecessary notifications for me and others.

client/src/components/Chat.jsx Outdated Show resolved Hide resolved
client/src/components/Chat/DropDownOption.jsx Show resolved Hide resolved
client/src/lib/chatHelper.js Outdated Show resolved Hide resolved
Copy link

vercel bot commented Jul 28, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper ❌ Failed (Inspect) Jul 28, 2024 9:54am
whisper-b2p2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 28, 2024 9:54am

client/src/App.jsx Outdated Show resolved Hide resolved
client/src/components/Chat/DropDownOption.jsx Outdated Show resolved Hide resolved
client/src/hooks/useCryptoKeys.js Outdated Show resolved Hide resolved
@Dun-sin
Copy link
Owner

Dun-sin commented Aug 6, 2024

@Golu7667 stiil interested in this?

@Dun-sin Dun-sin added the 7 days Not more than 7 days(1week) to raise a PR label Aug 6, 2024
Golu7667 and others added 2 commits August 7, 2024 14:33
Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project to your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

@Dun-sin Dun-sin merged commit 9acb3d9 into Dun-sin:main Aug 7, 2024
1 of 3 checks passed
Dun-sin added a commit that referenced this pull request Aug 7, 2024
@Dun-sin
Copy link
Owner

Dun-sin commented Aug 7, 2024

actually @Golu7667 can you raise the PR again, and don't add app.jsx, your method of reverting the file is wrong as it deleted the original from the source code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
7 days Not more than 7 days(1week) to raise a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Copying chat not work
2 participants