Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Moved hasActiveReply ternary condition outside of the class #686

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

zainab-a-ali
Copy link
Contributor

Fixes Issue

My PR closes #665

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

Moved the ternary condition outside of the className

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Copy link

vercel bot commented Aug 26, 2024

@zainab-a-ali is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

@zainab-a-ali
Copy link
Contributor Author

@Dun-sin I have opened a new PR cause I needed to change the branch name

Copy link
Owner

@Dun-sin Dun-sin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You did great, thanks for contributing, I hope you will stick around and continue to contribute to this project.

Consider giving this project a star, sharing the project with your friends, and joining the community discord server if you haven't for more resources and opportunities to connect with others. πŸ‘‰πŸ½hereπŸ‘ˆπŸ½

Copy link

vercel bot commented Aug 26, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper-b2p2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Aug 26, 2024 8:22am

@Dun-sin Dun-sin merged commit b25b4d0 into Dun-sin:main Aug 26, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[OTHER] define the hasActiveReply ternary condition outside of the class
2 participants