Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: crash when deleting a message #712

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

azr-arch
Copy link
Contributor

Fixes Issue

My PR closes #704

πŸ‘¨β€πŸ’» Changes proposed(What did you do ?)

  • Removed the unnecessary call to updateMessage to prevent crashing when deleting a message.
  • Updated the function to only call updateMessage when needed.

βœ”οΈ Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • This PR does not contain plagiarized content.
  • The title and description of the PR is clear and explains the approach.

Note to reviewers

πŸ“· Screenshots

delete.working.-.Made.with.Clipchamp.mp4

Copy link

vercel bot commented Oct 20, 2024

@azr-arch is attempting to deploy a commit to the dunsin's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks Passed!

@azr-arch azr-arch changed the title bug: fixes crash when deleting a message fix: crash when deleting a message Oct 20, 2024
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
whisper-b2p2 βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Oct 21, 2024 5:35pm

@Dun-sin Dun-sin merged commit c2dc613 into Dun-sin:main Oct 21, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Deleting a message crashes the app
2 participants