Merge pull request pharo-contributions#46 from DurieuxPol/fix/issues

Improvements to RandomMutantSelectionStrategyTest

src/MuTalk-Model/MethodMutation.class.st

@@ -23,6 +23,26 @@ MethodMutation class >> for: aMethod using: anOperatorApplied nodeNumber: aNodeN
 		 yourself
 ]
 
+{ #category : 'comparing' }
+MethodMutation >> = anObject [
+	"Two method mutations are equals if they have the same operator,if they mutate the same method from the same class, and if they have the same node number"
+
+	self == anObject ifTrue: [ ^ true ].
+	anObject species = self class ifFalse: [ ^ false ].
+	self operator species = anObject operator species ifFalse: [ ^ false ].
+	self originalMethod = anObject originalMethod ifFalse: [ ^ false ].
+	self originalClass = anObject originalClass ifFalse: [ ^ false ].
+	self nodeNumber = anObject nodeNumber ifFalse: [ ^ false ].
+	^ true
+]
+
+{ #category : 'comparing' }
+MethodMutation >> hash [
+
+	^ self operator species hash + self originalMethod hash
+	  + self originalClass hash + self nodeNumber hash
+]
+
 { #category : 'initialize-release' }
 MethodMutation >> initializeFor: aMethod using: anOperatorApplied nodeNumber: aNodeNumber ofClass: aClass [
 	originalMethod := aMethod.
@@ -53,6 +73,12 @@ MethodMutation >> mutatedNode [
 	^ operator applyTo: self nodeToMutate
 ]
 
+{ #category : 'accessing' }
+MethodMutation >> nodeNumber [
+
+	^ nodeNumber
+]
+
 { #category : 'accessing' }
 MethodMutation >> nodeNumber: anInteger [ 
 	nodeNumber := anInteger

src/MuTalk-Tests/RandomMutantSelectionStrategyTest.class.st

@@ -0,0 +1,43 @@
+Class {
+	#name : 'RandomMutantSelectionStrategyTest',
+	#superclass : 'TestCase',
+	#category : 'MuTalk-Tests',
+	#package : 'MuTalk-Tests'
+}
+
+{ #category : 'accessing' }
+RandomMutantSelectionStrategyTest >> classToTest [
+
+	^ RandomMutantSelectionStrategy
+]
+
+{ #category : 'tests' }
+RandomMutantSelectionStrategyTest >> testAtLeastTwoDifferentMutantCollectionsAmongFive [
+	"This test is to ensure that RandomMutantSelectionStrategy doesn't always produce the same mutant collections.
+	If it can produce at least two different collections, we assume it correctly randomize the inital mutant collection.
+	Here, two mutant collections are differents when their mutants are not in the same order."
+
+	| analysis mutationsSet |
+	"mutationsSet is a set of mutant collections"
+	mutationsSet := Set new.
+	1 to: 5 do: [ :i |
+		analysis := MutationTestingAnalysis
+			            testCasesFrom:
+			            { AuxiliarClassForMutationTestingAnalysisTest }
+			            mutating: { AuxiliarClassForMutationTestingAnalysis }
+			            using: MutantOperator contents
+			            with: AllTestsMethodsRunningTestSelectionStrategy new
+			            with: self classToTest new.
+		mutationsSet add: analysis generateMutations ].
+
+	"If the size of the set is at least 2, there is at least 2 different mutant collections, so at least 2 different orders of mutants."
+	self assert: mutationsSet size >= 2
+]
+
+{ #category : 'tests' }
+RandomMutantSelectionStrategyTest >> testDefaultMutationsGenerationStrategyIsAllMutantSelectionStrategy [
+
+	self
+		assert: self classToTest new mutationsGenerationStrategy species
+		equals: AllMutantSelectionStrategy new species
+]

src/MuTalk-Tests/RandomOperatorMutantSelectionStrategyTest.class.st

@@ -0,0 +1,12 @@
+Class {
+	#name : 'RandomOperatorMutantSelectionStrategyTest',
+	#superclass : 'RandomMutantSelectionStrategyTest',
+	#category : 'MuTalk-Tests',
+	#package : 'MuTalk-Tests'
+}
+
+{ #category : 'accessing' }
+RandomOperatorMutantSelectionStrategyTest >> classToTest [
+
+	^ RandomOperatorMutantSelectionStrategy
+]