Better support for C enum. #425
Conversation
macroslib/src/cpp/fenum.rs
Outdated
| file, | ||
| r"}}; | ||
|
|
||
| typedef enum {enum_name} {enum_name}Opaque; |
There was a problem hiding this comment.
All looks good, except of naming (the most complex question of programming).
"Opaque" elsewhere in crate used for some kind of type erasure.
So "opaque" is related to that real type is invisible from <Type>Opaque. In case of enum type is visible,
so I suggest name it in some other way. For example "C{enum_name}`
| // Important ! | ||
| // This new type needs to be named as 'SomeEnumOpaque', | ||
| // else this conflicts with C++ bindings code (type 'SomeEnum' is already defined there). | ||
| r#"enum SomeEnum { |
There was a problem hiding this comment.
In this case more robust test case would be to add the whole file content to test with "pragma once and so on",
to distinguish from C++ header. Because of this test passes even without new generate_c_code_for_enum,
because of C++ header contains the same code.
|
I see also a conflicting files, which was nos there previsously. You prefer different commits, or a squash of all ? |
I suppose "squash" is better for such small feature, too make life easier during "git bisect".
I removed empty line in enum generator, and I suppose this is cause conflicts. |
|
New tests added, after seeing the new |
Create a 'enum' in .h file, with same values than in C++. Difference are the names of the 'constants'. The enum name is prepended before the RUST enum value name. Minimal testing tools available. Note: generate_c_code_for_enum is renamed as generate_cpp_code_for_enum, as it is actually generating code for C++. generated_c_code_for_enum is created to generate C code ! Commit squashed after review. Added more tests, especially after the new enum syntax.
No. |
See discussion in #419.
Create a 'enum' in .h file, with same values than in C++.
Difference are the names of the 'constants' : In C, the enum name is prepended before the RUST enum name.
Testing tool are also available in tests/expectations.
Note:
generate_c_code_for_enumis renamed asgenerate_cpp_code_for_enum, as it is actually generating code for C++.generated_c_code_for_enumis created to generate C code !