fix: tabIdex was missing for discard/save buttons (#453)

Signed-off-by: Alejandro Parcet <[email protected]>
Dygmalab · Jun 26, 2023 · 74cdfda · 74cdfda
1 parent 0c19554
commit 74cdfda
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/src/renderer/component/Button/regularButton.js b/src/renderer/component/Button/regularButton.js
@@ -18,14 +18,15 @@
 import React from "react";
 import PropTypes from "prop-types";
 
-const RegularButton = ({ selected, onClick, size, buttonText, style, icoSVG, icoPosition, disabled }) => {
+const RegularButton = ({ selected, onClick, size, buttonText, style, icoSVG, icoPosition, disabled, tabIndex }) => {
   return (
     <div
       onClick={disabled ? () => {} : onClick}
       className={`${size ? size : ""} ${selected ? "active" : ""} button ${style && style} iconOn${
         icoPosition ? icoPosition : "None"
       }`}
       disabled={disabled}
+      tabIndex={tabIndex}
     >
       <div className={"buttonLabel"}>
         {icoSVG && icoPosition !== "right" ? icoSVG : ""}

diff --git a/src/renderer/modules/KeyPickerKeyboard/KeyPickerReduced.js b/src/renderer/modules/KeyPickerKeyboard/KeyPickerReduced.js
@@ -480,7 +480,7 @@ class KeyPickerReduced extends Component {
           icony={key.icony}
           iconsize={key.iconsize}
           disabled={key.mod == disableMods || key.move == disableMove || disableAll}
-          // disabled={false}
+          tabIndex={-1}
           idArray={key.idArray}
           keyCode={code}
         />

diff --git a/src/renderer/modules/Saving/Saving.js b/src/renderer/modules/Saving/Saving.js
@@ -27,13 +27,15 @@ const Saving = ({ saveContext, destroyContext, inContext }) => {
   return (
     <Style className="savingButtons">
       <RegularButton
+        tabIndex={0}
         onClick={destroyContext}
         buttonText={i18n.app.cancelPending.button}
         style="outline"
         size="sm"
         disabled={!inContext}
       />
       <RegularButton
+        tabIndex={0}
         onClick={saveContext}
         buttonText={i18n.components.save.button}
         style="primary"