Skip to content

Commit

Permalink
Run release only after testing is ok also fix warning
Browse files Browse the repository at this point in the history
Signed-off-by: Javier Guzman <[email protected]>
  • Loading branch information
javierguzman committed Jun 23, 2023
1 parent becc385 commit bd2a880
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 3 deletions.
8 changes: 7 additions & 1 deletion .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ on:
pull_request:
branches:
- "main"
workflow_run:
workflows:
- "Testing"
types:
- completed

permissions:
contents: read

Expand All @@ -23,7 +29,7 @@ jobs:
fail-fast: false
matrix:
include:
- os: macos-13
- os: macos-12
- os: windows-2019
- os: ubuntu-20.04

Expand Down
5 changes: 4 additions & 1 deletion .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
fail-fast: false
matrix:
include:
- os: macos-13
- os: macos-12
- os: windows-2019
- os: ubuntu-20.04

Expand All @@ -42,3 +42,6 @@ jobs:
- run: yarn run test
# - run: yarn run lint
# - run: yarn run test

outputs:
success: ${{ success() }}
2 changes: 1 addition & 1 deletion forge.config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ const config: ForgeConfig = {
const matchString = new RegExp(`prebuilds/${platform}`);
prebuilds.forEach(function (path) {
if (!path.match(matchString)) {
fs.rmdirSync(path, { recursive: true });
fs.rmSync(path, { recursive: true });
}
});
},
Expand Down

0 comments on commit bd2a880

Please sign in to comment.