-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Korean keyboard layout #380
Comments
Add Korean keyboard layout, it is almost the same as US ANSI re #380
Thanks @TaeksuKim for your support. I have already created a PR and if everything is ok, it will be available for the next release :) Next time feel free to open a PR yourself, you are more than welcome to contribute |
@javierguzman Thanks for your effort 👍 I was feeling a little bit worry that my PR had been created too long time ago. Thus, there might be misunderstandings or conflicts with current I'll happily wait the merge and new feature to support Korean language 😸 Thank you, now you may freely close this issue. With your kindness, I'll create PRs by myself without any worry from the next time. |
Hello @TaeksuKim there is a new release with the Korean layout, just to let you know. I hope everything works ok for you :) Again thank you! p.s. I close this issue |
@javierguzman Thanks for the notice. I've updated Bazecor and checked that all works!!! |
Is your feature request related to a problem? Please describe.
Korean keyboard layout is exactly same with English ANSI's one except just two extra keys:
LANGUAGE1
(0x90 = 144,한글
in Korean), a punctuator to toggle on/off Korean input modeLANGUAGE2
(0x91 = 145,한자
in Korean), a punctuator to translate a Korean character to Chinese characterHID codes
If those keys are supported by Bazecor, it will be really convenient for Koreans.
Describe the solution you'd like
Describe alternatives you've considered
N/A
Additional context
I've created a change set based on the development branch (545f9a4) .
You may find a pull request at TaeksuKim#3 .
Please refer attached screenshots.
May I create a pull request to development branch?
( Related issue is #304 )
The text was updated successfully, but these errors were encountered: