Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Extend ClearLayer #822

Merged
merged 10 commits into from
Jul 16, 2024

Conversation

folivaresrios
Copy link
Contributor

It is an improvement that allows selecting the entire keyboard or any of its sides to apply the layer cleaning.

clearlayer

It will remain in draft, as if I get a bit more motivated, I will apply these improvements to the color application.
Any suggestions or corrections are welcome.

Signed-off-by: Fabián Olivares Ríos <[email protected]>
Signed-off-by: Fabián Olivares Ríos <[email protected]>
Signed-off-by: Fabián Olivares Ríos <[email protected]>
Signed-off-by: Fabián Olivares Ríos <[email protected]>
Signed-off-by: Fabián Olivares Ríos <[email protected]>
Signed-off-by: Fabián Olivares Ríos <[email protected]>
@folivaresrios
Copy link
Contributor Author

Add:

Fix visual bug:
When opening the layer cleaning dialog, the default color selection and the 'no change' option are displayed because the component used (Dialog) has autofocus on the button. This was modified by a styled component to avoid it, as it does not have an 'initialFocus' in its API.

before:
CleanShot 2024-07-06 at 17 55 23

after:
CleanShot 2024-07-06 at 17 56 42

@folivaresrios folivaresrios marked this pull request as ready for review July 10, 2024 22:32
@alexpargon
Copy link
Contributor

Hey there @folivaresrios!

Seems like a very nice addition! i will review the changes and test it on my side!

@folivaresrios
Copy link
Contributor Author

Hey there @folivaresrios!

Seems like a very nice addition! i will review the changes and test it on my side!

Hey @alexpargon

When you have time, you can review this pull request #825. I Apply the same logic but in the color bar

@alexpargon alexpargon merged commit 0773d42 into Dygmalab:development Jul 16, 2024
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants