fix: handle hex colors without a preceeding # and refactor #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* function would return NaN in the matrix if supplied with a hex color without a preceeding # * eliminated double calls to parseInt when supplying a hex color * added handling for the case where supplied string is neither a hex nor rgb color (defaulting to black) * added tests Signed-off-by: Lawrence Brooks <[email protected]>
lbrooks
force-pushed
the
color-matrix-calculation-test
branch
from
050a4fb
to
f5ffa06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two edge cases for this two functions would result in NaN being contained within the returned color matrix:
Supplying a hex color string without a preceeding #
Supplying a string that was not in the hex or rgb color format.
This PR covers those two cases by:
Additionally this PR also