Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Efficient improvement with PureComponent #441

Closed
wants to merge 1 commit into from

Conversation

ifsnow
Copy link

@ifsnow ifsnow commented Apr 1, 2019

As you all know, unnecessary re-rendering can cause performance problems. I think using PureComponent is generally more efficient than not. The more logic is added to the render function, the greater the effect.

Please consider it positively. I hope this helps.

@DylanVann
Copy link
Owner

Making this a pure component may help some people with performance a bit, thanks for the contribution.

In this case I don't want to convert this back into a class component so I'm doing the same thing using React.memo - #449

@DylanVann DylanVann closed this Apr 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants