Skip to content

Commit

Permalink
i#1511: downgrade assert as invalid data from the kernel seems to be …
Browse files Browse the repository at this point in the history
…a real

possibility.  Needs further investigation.

SVN-Revision: 1871
  • Loading branch information
derekbruening committed Apr 5, 2014
1 parent d9be62e commit df2fb3d
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion drmemory/handlecheck.c
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ get_process_handle_list(void)
/* iterate over the whole handle list */
for (h_sys = &sys_list->Handle[0]; h_sys < h_sys_end; h_sys++) {
/* if pid is matched, count the handles in that chunk */
LOG(4, "%s: comparing pid=%d to %d\n", __FUNCTION__, pid, h_sys->OwnerPid);
if (h_sys->OwnerPid == pid) {
num_matched_pid++;
for (h_start = h_sys, count = 0;
Expand Down Expand Up @@ -242,7 +243,8 @@ get_process_handle_list(void)
} else {
if (pid < 0x10000) {
/* fail for unknown reason */
ASSERT(false, "fail to find the process in the handle list");
/* XXX i#1511: not an assert b/c it happens: we need to understand why */
WARN("WARNING: failed to find the process in the handle list");
break;
}
/* i#1389: we truncate the real pid to match the pid value returned
Expand Down

0 comments on commit df2fb3d

Please sign in to comment.