Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRASH drcachesim with fewer simulated cores than present in a core-sharded-on-disk trace #6778

Closed
derekbruening opened this issue Apr 18, 2024 · 0 comments · Fixed by #6779
Closed

CRASH drcachesim with fewer simulated cores than present in a core-sharded-on-disk trace #6778

derekbruening opened this issue Apr 18, 2024 · 0 comments · Fixed by #6779
Assignees
@derekbruening
Labels
Bug-ToolCrash Component-DrMemtrace

Comments

@derekbruening
Copy link
Contributor

The checked-in core-sharded-on-disk trace has 4 cores and if we pass fewer to dr$sim it just crashes:

$ bin64/drrun -t drcachesim -indir ../src/clients/drcachesim/tests/drmemtrace.threadsig-core-sharded.x64.tracedir/ -cores 3
@derekbruening derekbruening self-assigned this Apr 18, 2024
derekbruening added a commit that referenced this issue Apr 18, 2024
@derekbruening
i#6778: Gracefully handle too few drcachesim cpus
0cb5ea9 
Adds a check with an error message for too few simulated drcachesim
cpus with a core-sharded-on-disk trace.

Adds a unit test which crashes without the fix.

Also tested manually:
Before:
  $ bin64/drrun -t drcachesim -indir ../src/clients/drcachesim/tests/drmemtrace.threadsig-core-sharded.x64.tracedir/ -cores 3
  Segmentation fault
After:
  $ bin64/drrun -t drcachesim -indir ../src/clients/drcachesim/tests/drmemtrace.threadsig-core-sharded.x64.tracedir/ -cores 3
  ERROR: failed to run analyzer: Too-small core count 3 for trace core #3

Fixes #6778
@derekbruening derekbruening mentioned this issue Apr 18, 2024
Merged
derekbruening added a commit that referenced this issue Apr 18, 2024
@derekbruening
i#6778: Gracefully handle too few drcachesim cpus (#6779)
629dee7 
Adds a check with an error message for too few simulated drcachesim cpus
with a core-sharded-on-disk trace.

Adds a unit test which crashes without the fix.

Also tested manually:
Before:
$ bin64/drrun -t drcachesim -indir
../src/clients/drcachesim/tests/drmemtrace.threadsig-core-sharded.x64.tracedir/
-cores 3
  Segmentation fault
After:
$ bin64/drrun -t drcachesim -indir
../src/clients/drcachesim/tests/drmemtrace.threadsig-core-sharded.x64.tracedir/
-cores 3
ERROR: failed to run analyzer: Too-small core count 3 for trace core #3

Fixes #6778
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derekbruening derekbruening

Labels
Bug-ToolCrash Component-DrMemtrace
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

i#6778: Gracefully handle too few drcachesim cpus DynamoRIO/dynamorio
1 participant
@derekbruening