Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#1569 AArch64: Initialise variables in encoder functions. #2528

Merged
merged 1 commit into from
Jul 12, 2017

Conversation

egrimley
Copy link
Contributor

Add some unnecessary initialisers to prevent certain compiler versions
from breaking the build by incorrectly claiming that certain variables
"may be used uninitialized".

Change-Id: I8d9bf5497e64e464d3e7e49a3ba7db8daea3ac69

Add some unnecessary initialisers to prevent certain compiler versions
from breaking the build by incorrectly claiming that certain variables
"may be used uninitialized".

Change-Id: I8d9bf5497e64e464d3e7e49a3ba7db8daea3ac69
@egrimley egrimley requested a review from fhahn July 12, 2017 10:36
@egrimley
Copy link
Contributor Author

run aarch64 tests

Copy link
Contributor

@fhahn fhahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This should fix the nightly build errors on AArch64 dynamorio.org/CDash/viewBuildError.php?type=0&buildid=26203

src2 is definitely initialized if it is used in the function at line 5086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants