i#2557: fix fencepost error in find_free_memory_in_region() #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes an error where find_free_memory_in_region() thinks that an occupied region that spans the requested endpoint is free, resulting in an infinite loop in os_heap_reserve_in_region(). Manually tested on the app whose maps file hit this. (Creating a suite test is non-trivial without a mock for the maps iterator.) Fixes #2557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an error where find_free_memory_in_region() thinks that an occupied
region that spans the requested endpoint is free, resulting in an infinite
loop in os_heap_reserve_in_region().
Manually tested on the app whose maps file hit this. (Creating a suite
test is non-trivial without a mock for the maps iterator.)
Fixes #2557