fix: opnd_shared.c #3400
Merged
fix: opnd_shared.c #3400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
run arm tests |
derekbruening
approved these changes
Feb 28, 2019
|
Turns out there was an issue for this bug: #2900. It would be nice to add a test to ensure coverage of that RRX code but we'll put the fix in separately here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As commented by @egrimley in #3381 and #3382, this patch is required in order to build DynamoRIO with GCC7.
He commented that "That bug should be fixed in any case. I thought it had been.". So, I don't know if this patch is already present in some other branch that has not been merged yet.
Anyway, I know that the commit message is not correct, but I don't know the motivation for the change. Indeed, I neither know whether it should be specific to GCC 7. Therefore, I am opening this issue to let the CI tools check it agains other versions.