Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i#3496: Fix crash in drmgr-test #4008

Merged
merged 2 commits into from
Jan 10, 2020
Merged

i#3496: Fix crash in drmgr-test #4008

merged 2 commits into from
Jan 10, 2020

Conversation

derekbruening
Copy link
Contributor

Makes the XSAVE buffer large enough to avoid buffer overflow which was
crashing drmgr-test.

Fixes #3496

@derekbruening
i#3496: Fix crash in drmgr-test
da008a5 
Makes the XSAVE buffer large enough to avoid buffer overflow which was
crashing drmgr-test.

Fixes #3496
@derekbruening derekbruening mentioned this pull request Jan 10, 2020
Merged
@derekbruening
Copy link
Contributor Author

AArch64 failure is drcachesim.invariants (again...grrr): #3980

@derekbruening derekbruening mentioned this pull request Jan 10, 2020
Merged
Carrotman42
Carrotman42 approved these changes Jan 10, 2020
View reviewed changes
Copy link
Contributor

@Carrotman42 Carrotman42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay

@derekbruening
Copy link
Contributor Author

Wow so much redness still: #3980 on AArch64, #3406: code_api|linux.fib-conflict-early on Travis.

@derekbruening derekbruening merged commit d36d1dc into master Jan 10, 2020
@derekbruening derekbruening deleted the i3496-drmgr-test branch January 10, 2020 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carrotman42 Carrotman42 Carrotman42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test client.drmgr-test failing with "signal not correct" on modern Linux machine.
2 participants
@derekbruening @Carrotman42