Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#4087: Statically retarget libelftc malloc to DR #4094

Merged
merged 7 commits into from
Feb 14, 2020

Conversation

derekbruening
Copy link
Contributor

Re-builds the ELF libeltc binaries to directly target the _wrap
versions of malloc, calloc, realloc, and free. This avoids libc for
statically linked uses rather than solely relying on the DR private
loader to redirect. Updates all of the binaries: aarch64, android,
arm EABI, arm EABIHF, macho, pecoff lib32, pecoff lib64.

Fixes #4087

Re-builds the ELF libeltc binaries to directly target the __wrap_
versions of malloc, calloc, realloc, and free.  This avoids libc for
statically linked uses rather than solely relying on the DR private
loader to redirect.  Updates *all* of the binaries: aarch64, android,
arm EABI, arm EABIHF, macho, pecoff lib32, pecoff lib64.

Fixes #4087
@AssadHashmi
Copy link
Contributor

run arm tests

Changes the __wrap_ and redirect_ malloc routines to be cross-platform
and usable on Windows.

Clang-formats the libelftc headers we share.

Adds strdup redirection.  Updates the x86, pecoff, and macho libelftc
binaries for strdup and r3530.

Adds notes about r3531 libelftc bug to x86, pecoff, and macho.

Fixes libelftc-pecoff.patch which had all the added files stripped out
by e345a54!!
@derekbruening
Copy link
Contributor Author

The Travis failure is the new Mac64 non-det assert under #1979 which I am separately working on addressing (PR #4096).

@derekbruening derekbruening merged commit 7fd5d95 into master Feb 14, 2020
@derekbruening derekbruening deleted the i4087-libelftc-malloc branch February 14, 2020 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drcachesim function tracing uses malloc which is disallowed for static linkage
2 participants