-
Notifications
You must be signed in to change notification settings - Fork 561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i#4334: Fix leaks on thread exit #4350
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These leaks are all cleaned up at process exit, which is why the existing exit-time leak checks don't notice anything. The global block list lets us clean them up later, and hence a classic reachability-based leak detector would not catch them either: so perhaps they should be called "reachable accumulations" instead of "leaks". Fixes a memory leak on thread exit in all builds: + The private reachable_heap units were not being freed Fixes a number of memory leaks on thread exit in release build: + Adds individual private fragment deletion on thread exit, to free stubs if -separate_private_stubs is on. Turns off -separate_private_stubs by default, to avoid this for shared caches where there are few benefits to separating private stubs. -thread_private turns it back on where the benefits probably outweight the thread exit costs. + Moves the privload_tls_exit call to release build too to properly unmap the TLS. + Moves the sigaltstack free to release build to properly free it. + Moves freeing of "local unprotected" heap to the release-build path, since it is actually global! This is done for kstats, stats, and clone_tls. + Moves client_data_t, client_todo_list_t, and thread-private client_flush_req_t to be PROTECTED to make it thread-local and thus not need freeing (the free is avoided for i#271). Adds an -rstats_to_stderr dump point when DR terminates for OOM to make it much easier to diagnose what the problem is. Adds a new api.thread_churn test which attaches twice, once with a few threads and once with many threads, and confirms memory usage has not gone up. The 5 rstats on peak vmm block sizes are added to dr_stats_t to facilitate this. I tried to get api.thread_churn to work on Windows but hit a number of issues with reattach. I solved two of them before bailing and making the test UNIX-only for now and filed the rest as #4349. + Unprotect .data on reattach + Clear the logfile flag on detach Issue: #4334, #271, #4349 Fixes #4334
johnfxgalea
reviewed
Jul 2, 2020
johnfxgalea
approved these changes
Jul 2, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
abhinav92003
added a commit
that referenced
this pull request
Jul 2, 2020
This reverts commit 94c8ad4.
abhinav92003
added a commit
that referenced
this pull request
Jul 2, 2020
This reverts commit 50b3e04.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These leaks are all cleaned up at process exit, which is why the
existing exit-time leak checks don't notice anything. The global
block list lets us clean them up later, and hence a classic
reachability-based leak detector would not catch them either: so
perhaps they should be called "reachable accumulations" instead of
"leaks".
Fixes a memory leak on thread exit in all builds:
Fixes a number of memory leaks on thread exit in release build:
stubs if -separate_private_stubs is on.
Turns off -separate_private_stubs by default, to avoid this for
shared caches where there are few benefits to separating private stubs.
-thread_private turns it back on where the benefits probably outweight
the thread exit costs.
unmap the TLS.
since it is actually global! This is done for kstats, stats, and
clone_tls.
client_flush_req_t to be PROTECTED to make it thread-local and thus
not need freeing (the free is avoided for i#271).
Adds an -rstats_to_stderr dump point when DR terminates for OOM to
make it much easier to diagnose what the problem is.
Adds a new api.thread_churn test which attaches twice, once with a few
threads and once with many threads, and confirms memory usage has not
gone up. The 5 rstats on peak vmm block sizes are added to dr_stats_t
to facilitate this.
I tried to get api.thread_churn to work on Windows but hit a number of
issues with reattach. I solved two of them before bailing and making
the test UNIX-only for now and filed the rest as #4349.
Issue: #4334, #271, #4349
Fixes #4334