i#4462: Add new global memtrace size limit #4479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new drcachesim memtrace option -max_global_trace_refs to supply a global trace size limit that does not kill the process. When the maximum is reached, the tracer omits traces for new threads entirely. Add an online and an offline test for the feature. Adds documentation. Fixes #4462
|
run arm tests |
|
a64 is drwrap detach test which we now know sometimes hangs (see #4467 (comment)) b/c a64 detach is still not solid (#1578). Re-running. |
abhinav92003
reviewed
Oct 8, 2020
…per for existing trace_max checks; rename helper; add regex on instr count to test; augment reattach comment
abhinav92003
reviewed
Oct 8, 2020
abhinav92003
approved these changes
Oct 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new drcachesim memtrace option -max_global_trace_refs to supply
a global trace size limit that does not kill the process. When the
maximum is reached, the tracer omits traces for new threads entirely.
Add an online and an offline test for the feature.
Adds documentation.
Fixes #4462