i#5843 scheduler: Move timestamp ordering into scheduler #5895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements timestamp ordering in scheduler_t rather than relying on the old implementation inside file_reader_t. Adds a sanity test. Removing the file_reader_t code, along with eliminating the thread-as-sub-reader API routines, will be done as a separate refactoring. Issue: #5843
|
Sorry, it wasn't quite green: two one-line fixes to deal with compiler warnings and now it is green. PTAL. |
brettcoon
reviewed
Mar 8, 2023
…t in init(); fix only_threads bug and add test; add comments; augment sort test
brettcoon
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements timestamp ordering in scheduler_t rather than relying on the old implementation inside file_reader_t.
Adds a sanity test.
Removing the file_reader_t code, along with eliminating the thread-as-sub-reader API routines, will be done as a separate refactoring.
Issue: #5843