Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i#5843 scheduler: Accumulate quanta across runs #6502

Merged
merged 3 commits into from
Dec 12, 2023

Conversation

derekbruening
Copy link
Contributor

Changes the quanta accounting to match the real kernel by accumulating it across executions if a prior execution was terminated early due to a voluntary context switch.

Adds new testing, and updates old tests with the behavior change. Scheduler unit test string changes were carefully vetted. E.g., for test_synthetic_with_syscalls_multiple(): the output strings changed because H's quantum accumulates and it hits a preempt in the middle of its second HH sequence, which decrements B's quantum, causing B to become available sooner.

Issue: #5843

Changes the quanta accounting to match the real kernel by accumulating
it across executions if a prior execution was terminated early due to
a voluntary context switch.

Adds new testing, and updates old tests with the behavior change.
Scheduler unit test string changes were carefully vetted.  E.g., for
test_synthetic_with_syscalls_multiple(): the output strings changed
because H's quantum accumulates and it hits a preempt in the middle of
its second HH sequence, which decrements B's quantum, causing B to
become available sooner.

Issue: #5843
@derekbruening
Copy link
Contributor Author

a64 had some weird seemingly unrelated failures but the machine turned out to be out of disk space (discovered in the middle of this re-run).

clients/drcachesim/scheduler/scheduler.cpp Outdated Show resolved Hide resolved
@derekbruening
Copy link
Contributor Author

x64 failure is client.attach_test not finding the process to kill: #6452
x32 is #6417

@derekbruening derekbruening merged commit 278fc51 into master Dec 12, 2023
13 of 15 checks passed
@derekbruening derekbruening deleted the i5843-quantum-accum branch December 12, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants