This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Workaround for unready informer in Nodes controller #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DTMad
approved these changes
Mar 23, 2020
lrgar
force-pushed
the
bugfix/nodes-workaround
branch
from
2ecef28
to
775b687
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw the case of an error message on the Nodes Controller where the Informers is not ready. This shouldn't happen, but just in case, when the watcher for deletions fail, here I'm ignoring the error and continuing so that the Operator doesn't exit.
Deletions will be seen in the periodic check every five minutes however, so the feature most likely will work anyway.