-
Notifications
You must be signed in to change notification settings - Fork 48
Conversation
77df505
to
ee86e0f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will this cause confusion when the user needs to know that annotation flavor is actually the same as custom resource field libc. It will get even more strange when values of them do not match: musl
vs. default
vs. glibc
.
Therefore, shouldn't we simply stick with the term flavor?
deploy/cr-apm.yaml
Outdated
# Optional: define which core library for C should be used. | ||
# Can be set to "musl" to use musl instead of glibc | ||
# | ||
# libc: "musl" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can it be set to glibc
as well?
deploy/cr-apm.yaml
Outdated
@@ -49,3 +50,8 @@ spec: | |||
# limits: | |||
# cpu: 500m | |||
# memory: 100M | |||
|
|||
# Optional: define which core library for C should be used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be rephrased to "defines the C standard library used."
// Optional: define which core library for C should be used. | ||
// Can be set to "musl" to use musl instead of glibc | ||
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors=true | ||
// +operator-sdk:gen-csv:customresourcedefinitions.specDescriptors.displayName="C Core Library" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use C standard library as well.
pkg/webhook/server/flavor.go
Outdated
if flavor != "musl" { | ||
return "default" | ||
} | ||
return flavor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if flavor != "musl" { | |
return "default" | |
} | |
return flavor | |
if flavor = "musl" { | |
return flavor | |
} | |
return "default |
extended property description
No description provided.