Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cryo terms to coupler budget #74

Closed
wants to merge 15 commits into from
Closed

Add cryo terms to coupler budget #74

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
efbd115
Adding cryo coupling fields and budget terms (ismw broken)
darincomeau Jan 26, 2024
10691dd
Changing scaling for ice-shelf cavities
darincomeau Jan 26, 2024
4e16416
Calling in dataLandIceFreshwaterFlux also
darincomeau Jan 26, 2024
8295de2
Commenting out wberg calculation in ice column
darincomeau Jan 29, 2024
d42b9cb
Accumulate added fluxes over coupling interval
darincomeau Feb 1, 2024
6cc7a1e
Fixing errors in logicals
darincomeau Feb 2, 2024
947d2fb
Separate out prognostic and data ismf accumulation
darincomeau Feb 5, 2024
23624db
Adding data option for land ice fluxes in ocn conservation analysis m…
darincomeau Feb 7, 2024
6ca4e69
Fixing errors in logicals (again)
darincomeau Feb 9, 2024
842cc37
Cleaning up after debugging
darincomeau Feb 9, 2024
d46f9b2
Removing 'P' from ismw coupler index
darincomeau Feb 9, 2024
4951935
Bringing on the heat
darincomeau Feb 9, 2024
dbe3477
Changing units to W/m^2
darincomeau Feb 9, 2024
e68e422
Fixup units of accumulated mass fluxes in conservation AM
cbegeman Feb 7, 2024
5d3f8c1
cleaning up comments
darincomeau Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion components/mpas-ocean/driver/mpaso_cpl_indices.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ module mpaso_cpl_indices
integer :: index_o2x_Faoo_fco2_ocn
integer :: index_o2x_Faoo_fdms_ocn
integer :: index_o2x_So_ssh

integer :: index_o2x_Foxo_ismw
integer :: index_o2x_Foxo_rrofl
integer :: index_o2x_Foxo_rrofi

! ocn -> drv for calculation of ocean-ice sheet interactions

Expand Down Expand Up @@ -187,6 +189,10 @@ subroutine mpaso_cpl_indices_set( )
index_o2x_Faoo_fco2_ocn = mct_avect_indexra(o2x,'Faoo_fco2_ocn',perrWith='quiet')
index_o2x_Faoo_fdms_ocn = mct_avect_indexra(o2x,'Faoo_fdms_ocn',perrWith='quiet')
index_o2x_So_ssh = mct_avect_indexra(o2x,'So_ssh')
!DC P needed since in ice-shelf ocean domain?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noting I added 'P' for the ice-shelf melt term; I'm not sure if this matters with the way I did the scaling below. The removed runoff terms do not have P.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested without the 'P' and get the same answers, so I'm removing this.

index_o2x_Foxo_ismw = mct_avect_indexra(o2x,'PFoxo_ismw')
index_o2x_Foxo_rrofl = mct_avect_indexra(o2x,'Foxo_rrofl')
index_o2x_Foxo_rrofi = mct_avect_indexra(o2x,'Foxo_rrofi')

index_o2x_So_blt = mct_avect_indexra(o2x,'So_blt')
index_o2x_So_bls = mct_avect_indexra(o2x,'So_bls')
Expand Down
54 changes: 52 additions & 2 deletions components/mpas-ocean/driver/ocn_comp_mct.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2694,7 +2694,11 @@ subroutine ocn_export_mct(o2x_o, errorCode) !{{{
avgOceanSurfaceDOCSemiLabile, &
avgOceanSurfaceFeParticulate, &
avgOceanSurfaceFeDissolved, &
ssh
ssh, &
landIceFreshwaterFlux, &
dataLandIceFreshwaterFlux, &
removedRiverRunoffFlux, &
removedIceRunoffFlux

real (kind=RKIND), dimension(:,:), pointer :: avgTracersSurfaceValue, avgSurfaceVelocity, &
avgSSHGradient, avgOceanSurfacePhytoC, &
Expand All @@ -2703,6 +2707,7 @@ subroutine ocn_export_mct(o2x_o, errorCode) !{{{
real (kind=RKIND) :: surfaceFreezingTemp

logical, pointer :: frazilIceActive, &
config_remove_AIS_coupler_runoff, &
config_use_ecosysTracers, &
config_use_DMSTracers, &
config_use_MacroMoleculesTracers, &
Expand All @@ -2719,6 +2724,7 @@ subroutine ocn_export_mct(o2x_o, errorCode) !{{{
call mpas_pool_get_package(domain % packages, 'frazilIceActive', frazilIceActive)
call mpas_pool_get_config(domain % configs, 'config_use_ecosysTracers', config_use_ecosysTracers)
call mpas_pool_get_config(domain % configs, 'config_land_ice_flux_mode', config_land_ice_flux_mode)
call mpas_pool_get_config(domain % configs, 'config_remove_AIS_coupler_runoff', config_remove_AIS_coupler_runoff)
call mpas_pool_get_config(domain % configs, 'config_use_DMSTracers', config_use_DMSTracers)
call mpas_pool_get_config(domain % configs, 'config_use_MacroMoleculesTracers', config_use_MacroMoleculesTracers)
call mpas_pool_get_config(domain % configs, 'config_use_ecosysTracers_sea_ice_coupling', &
Expand Down Expand Up @@ -2761,6 +2767,18 @@ subroutine ocn_export_mct(o2x_o, errorCode) !{{{
call mpas_pool_get_array(statePool, 'accumulatedFrazilIceMass', accumulatedFrazilIceMass, 1)
end if

!DC Cryo fields
if (config_land_ice_flux_mode == 'standalone') then
call mpas_pool_get_array(forcingPool, 'landIceFreshwaterFlux', landIceFreshwaterFlux)
endif
if (config_land_ice_flux_mode == 'data') then
call mpas_pool_get_array(forcingPool, 'dataLandIceFreshwaterFlux', dataLandIceFreshwaterFlux)
endif
if (config_remove_AIS_coupler_runoff) then
call mpas_pool_get_array(forcingPool, 'removedRiverRunoffFlux', removedRiverRunoffFlux)
call mpas_pool_get_array(forcingPool, 'removedIceRunoffFlux', removedIceRunoffFlux)
endif

! BGC fields
if (config_use_ecosysTracers) then

Expand Down Expand Up @@ -2812,6 +2830,18 @@ subroutine ocn_export_mct(o2x_o, errorCode) !{{{

o2x_o % rAttr(index_o2x_Faoo_h2otemp, n) = avgTotalFreshWaterTemperatureFlux(i) * rho_sw * cp_sw

!DC
if (config_land_ice_flux_mode == 'standalone') then
o2x_o % rAttr(index_o2x_Foxo_ismw, n) = landIceFreshwaterFlux(i)
endif
if (config_land_ice_flux_mode == 'data') then
o2x_o % rAttr(index_o2x_Foxo_ismw, n) = dataLandIceFreshwaterFlux(i)
endif
if (config_remove_AIS_coupler_runoff) then
o2x_o % rAttr(index_o2x_Foxo_rrofl, n) = removedRiverRunoffFlux(i)
o2x_o % rAttr(index_o2x_Foxo_rrofi, n) = removedIceRunoffFlux(i)
endif

if ( frazilIceActive ) then
! negative when frazil ice can be melted
keepFrazil = .true.
Expand Down Expand Up @@ -3590,6 +3620,7 @@ subroutine ocn_import_moab( Eclock, errorCode)!{{{
endif

if ( landIceFreshwaterFluxField % isActive ) then
!DC is this ok with proposed implementation? think so since different coupling field
!landIceFreshwaterFlux(i) = x2o_om(n, index_x2o_Fogx_qicelo)
end if
if ( landIceHeatFluxField % isActive ) then
Expand Down Expand Up @@ -3984,6 +4015,7 @@ subroutine ocn_export_moab(EClock) !{{{
real (kind=RKIND) :: surfaceFreezingTemp

logical, pointer :: frazilIceActive, &
config_remove_AIS_coupler_runoff, &
config_use_ecosysTracers, &
config_use_DMSTracers, &
config_use_MacroMoleculesTracers, &
Expand All @@ -4000,6 +4032,7 @@ subroutine ocn_export_moab(EClock) !{{{
call mpas_pool_get_package(domain % packages, 'frazilIceActive', frazilIceActive)
call mpas_pool_get_config(domain % configs, 'config_use_ecosysTracers', config_use_ecosysTracers)
call mpas_pool_get_config(domain % configs, 'config_land_ice_flux_mode', config_land_ice_flux_mode)
call mpas_pool_get_config(domain % configs, 'config_remove_AIS_coupler_runoff', config_remove_AIS_coupler_runoff)
call mpas_pool_get_config(domain % configs, 'config_use_DMSTracers', config_use_DMSTracers)
call mpas_pool_get_config(domain % configs, 'config_use_MacroMoleculesTracers', config_use_MacroMoleculesTracers)
call mpas_pool_get_config(domain % configs, 'config_use_ecosysTracers_sea_ice_coupling', &
Expand Down Expand Up @@ -4041,6 +4074,14 @@ subroutine ocn_export_moab(EClock) !{{{
call mpas_pool_get_array(forcingPool, 'frazilSurfacePressure', frazilSurfacePressure)
call mpas_pool_get_array(statePool, 'accumulatedFrazilIceMass', accumulatedFrazilIceMass, 1)
end if

if (config_land_ice_flux_mode == 'standalone' .or. 'data') then
xylar marked this conversation as resolved.
Show resolved Hide resolved
call mpas_pool_get_array(forcingPool, 'landIceFreshwaterFlux', landIceFreshwaterFlux)
endif
if (config_remove_AIS_coupler_runoff) then
call mpas_pool_get_array(forcingPool, 'removedRiverRunoffFlux', removedRiverRunoffFlux)
call mpas_pool_get_array(forcingPool, 'removedIceRunoffFlux', removedIceRunoffFlux)
endif

! BGC fields
if (config_use_ecosysTracers) then
Expand Down Expand Up @@ -4092,7 +4133,16 @@ subroutine ocn_export_moab(EClock) !{{{
o2x_om(n, index_o2x_So_dhdy) = avgSSHGradient(index_avgMeridionalSSHGradient, i)

o2x_om(n, index_o2x_Faoo_h2otemp) = avgTotalFreshWaterTemperatureFlux(i) * rho_sw * cp_sw


!DC, blindly following pattern
if (config_land_ice_flux_mode == 'standalone' .or. 'data') then
xylar marked this conversation as resolved.
Show resolved Hide resolved
o2x_om(n, index_o2x_Foxo_ismw) = landIceFreshwaterFlux(i)
endif
if (config_remove_AIS_coupler_runoff) then
o2x_om(n, index_o2x_Foxo_rrofl) = removedRiverRunoffFlux(i)
o2x_om(n, index_o2x_Foxo_rrofi) = removedIceRunoffFlux(i)
endif

if ( frazilIceActive ) then
! negative when frazil ice can be melted
keepFrazil = .true.
Expand Down
80 changes: 51 additions & 29 deletions driver-mct/main/seq_diag_mct.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,32 +144,35 @@ module seq_diag_mct
integer(in),parameter :: f_wmelt =14 ! water: melting
integer(in),parameter :: f_wrain =15 ! water: precip, liquid
integer(in),parameter :: f_wsnow =16 ! water: precip, frozen
integer(in),parameter :: f_wberg =17 ! water: data icebergs
integer(in),parameter :: f_wevap =18 ! water: evaporation
integer(in),parameter :: f_wroff =19 ! water: runoff/flood
integer(in),parameter :: f_wioff =20 ! water: frozen runoff
integer(in),parameter :: f_wirrig =21 ! water: irrigation
integer(in),parameter :: f_wfrz_16O =22 ! water: freezing
integer(in),parameter :: f_wmelt_16O =23 ! water: melting
integer(in),parameter :: f_wrain_16O =24 ! water: precip, liquid
integer(in),parameter :: f_wsnow_16O =25 ! water: precip, frozen
integer(in),parameter :: f_wevap_16O =26 ! water: evaporation
integer(in),parameter :: f_wroff_16O =27 ! water: runoff/flood
integer(in),parameter :: f_wioff_16O =28 ! water: frozen runoff
integer(in),parameter :: f_wfrz_18O =29 ! water: freezing
integer(in),parameter :: f_wmelt_18O =30 ! water: melting
integer(in),parameter :: f_wrain_18O =31 ! water: precip, liquid
integer(in),parameter :: f_wsnow_18O =32 ! water: precip, frozen
integer(in),parameter :: f_wevap_18O =33 ! water: evaporation
integer(in),parameter :: f_wroff_18O =34 ! water: runoff/flood
integer(in),parameter :: f_wioff_18O =35 ! water: frozen runoff
integer(in),parameter :: f_wfrz_HDO =36 ! water: freezing
integer(in),parameter :: f_wmelt_HDO =37 ! water: melting
integer(in),parameter :: f_wrain_HDO =38 ! water: precip, liquid
integer(in),parameter :: f_wsnow_HDO =39 ! water: precip, frozen
integer(in),parameter :: f_wevap_HDO =40 ! water: evaporation
integer(in),parameter :: f_wroff_HDO =41 ! water: runoff/flood
integer(in),parameter :: f_wioff_HDO =42 ! water: frozen runoff
integer(in),parameter :: f_wevap =17 ! water: evaporation
integer(in),parameter :: f_wroff =18 ! water: runoff/flood
integer(in),parameter :: f_wioff =19 ! water: frozen runoff
integer(in),parameter :: f_wberg =20 ! water: data icebergs
integer(in),parameter :: f_wism =21 ! water: ice-shelf melt
integer(in),parameter :: f_wrrof =22 ! water: removed liquid runoff
integer(in),parameter :: f_wriof =23 ! water: removed ice runoff
integer(in),parameter :: f_wirrig =24 ! water: irrigation
integer(in),parameter :: f_wfrz_16O =25 ! water: freezing
integer(in),parameter :: f_wmelt_16O =26 ! water: melting
integer(in),parameter :: f_wrain_16O =27 ! water: precip, liquid
integer(in),parameter :: f_wsnow_16O =28 ! water: precip, frozen
integer(in),parameter :: f_wevap_16O =29 ! water: evaporation
integer(in),parameter :: f_wroff_16O =30 ! water: runoff/flood
integer(in),parameter :: f_wioff_16O =31 ! water: frozen runoff
integer(in),parameter :: f_wfrz_18O =32 ! water: freezing
integer(in),parameter :: f_wmelt_18O =33 ! water: melting
integer(in),parameter :: f_wrain_18O =34 ! water: precip, liquid
integer(in),parameter :: f_wsnow_18O =35 ! water: precip, frozen
integer(in),parameter :: f_wevap_18O =36 ! water: evaporation
integer(in),parameter :: f_wroff_18O =37 ! water: runoff/flood
integer(in),parameter :: f_wioff_18O =38 ! water: frozen runoff
integer(in),parameter :: f_wfrz_HDO =39 ! water: freezing
integer(in),parameter :: f_wmelt_HDO =40 ! water: melting
integer(in),parameter :: f_wrain_HDO =41 ! water: precip, liquid
integer(in),parameter :: f_wsnow_HDO =42 ! water: precip, frozen
integer(in),parameter :: f_wevap_HDO =43 ! water: evaporation
integer(in),parameter :: f_wroff_HDO =44 ! water: runoff/flood
integer(in),parameter :: f_wioff_HDO =45 ! water: frozen runoff

integer(in),parameter :: f_size = f_wioff_HDO ! Total array size of all elements
integer(in),parameter :: f_a = f_area ! 1st index for area
Expand All @@ -190,7 +193,8 @@ module seq_diag_mct
(/' area',' hfreeze',' hmelt',' hnetsw',' hlwdn', &
' hlwup',' hlatvap',' hlatfus',' hiroff',' hsen', &
' hberg',' hh2otemp',' wfreeze',' wmelt',' wrain', &
' wsnow',' wberg',' wevap',' wrunoff',' wfrzrof', &
' wsnow',' wevap',' wrunoff',' wfrzrof', &
' wberg',' wism',' wrrof',' wriof', &
' wirrig', &
' wfreeze_16O',' wmelt_16O',' wrain_16O',' wsnow_16O', &
' wevap_16O',' wrunoff_16O',' wfrzrof_16O', &
Expand Down Expand Up @@ -287,6 +291,10 @@ module seq_diag_mct
integer :: index_o2x_Faoo_h2otemp
integer :: index_o2x_Fioo_frazil
integer :: index_o2x_Fioo_q
!DC - do we want P in front of these fields?
integer :: index_o2x_Foxo_ismw
integer :: index_o2x_Foxo_rrofl
integer :: index_o2x_Foxo_rrofi

integer :: index_xao_Faox_lwup
integer :: index_xao_Faox_lat
Expand Down Expand Up @@ -1337,7 +1345,7 @@ subroutine seq_diag_ocn_mct( ocn, xao_o, frac_o, infodata, do_o2x, do_x2o, do_xa
integer(in) :: kArea ! index of area field in aVect
integer(in) :: ko,ki ! fraction indices
integer(in) :: lSize ! size of aVect
real(r8) :: ca_i,ca_o ! area of a grid cell
real(r8) :: ca_i,ca_o,ca_c ! area of a grid cell
logical,save :: first_time = .true.
logical,save :: flds_wiso_ocn = .false.

Expand Down Expand Up @@ -1373,17 +1381,26 @@ subroutine seq_diag_ocn_mct( ocn, xao_o, frac_o, infodata, do_o2x, do_x2o, do_xa
index_o2x_Fioo_frazil = mct_aVect_indexRA(o2x_o,'Fioo_frazil')
index_o2x_Fioo_q = mct_aVect_indexRA(o2x_o,'Fioo_q')
index_o2x_Faoo_h2otemp = mct_aVect_indexRA(o2x_o,'Faoo_h2otemp')
index_o2x_Foxo_ismw = mct_aVect_indexRA(o2x_o,'PFoxo_ismw')
index_o2x_Foxo_rrofl = mct_aVect_indexRA(o2x_o,'Foxo_rrofl')
index_o2x_Foxo_rrofi = mct_aVect_indexRA(o2x_o,'Foxo_rrofi')
end if

lSize = mct_avect_lSize(o2x_o)
ic = c_ocn_or
do n=1,lSize
ca_o = dom_o%data%rAttr(kArea,n) * frac_o%rAttr(ko,n)
ca_i = dom_o%data%rAttr(kArea,n) * frac_o%rAttr(ki,n)
ca_c = dom_o%data%rAttr(kArea,n) !DC area including ice-shelf cavities
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding this as a scaling factor was a bit of guesswork, but seems to work. Without it, I was getting 0 for ice-shelf melt in the coupler table, I think because the coupler is seeing the ice-shelf cavity grid cells as land, so 0 area for ocean and ice.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar here is where I got around the coupler masking out ocean cells under ice shelves.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it. Thanks!

nf = f_area; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + ca_o
nf = f_wfrz; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) - (ca_o+ca_i)*max(0.0_r8,o2x_o%rAttr(index_o2x_Fioo_frazil,n))
nf = f_hfrz; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*max(0.0_r8,o2x_o%rAttr(index_o2x_Fioo_q,n))
nf = f_hh2ot; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*o2x_o%rAttr(index_o2x_Faoo_h2otemp,n)
!DC do we need only ca_o, if use P above?
! nf = f_wism; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*o2x_o%rAttr(index_o2x_Foxo_ismw,n) ! gives 0, different scaling?
nf = f_wism; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + ca_c*o2x_o%rAttr(index_o2x_Foxo_ismw,n) ! think this is right scaling
nf = f_wrrof; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) - (ca_o+ca_i)*o2x_o%rAttr(index_o2x_Foxo_rrofl,n)
nf = f_wriof; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) - (ca_o+ca_i)*o2x_o%rAttr(index_o2x_Foxo_rrofi,n)
end do
end if

Expand Down Expand Up @@ -1495,6 +1512,10 @@ subroutine seq_diag_ocn_mct( ocn, xao_o, frac_o, infodata, do_o2x, do_x2o, do_xa
nf = f_wrain ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*x2o_o%rAttr(index_x2o_Faxa_rain,n)
nf = f_wsnow ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*x2o_o%rAttr(index_x2o_Faxa_snow,n)
nf = f_wberg ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*x2o_o%rAttr(index_x2o_Fioi_bergw,n)
!DC new entries should not be here, done above with o2x
! nf = f_wism ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*x2o_o%rAttr(index_x2o_Fioi_bergw,n)
! nf = f_wrrof ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*x2o_o%rAttr(index_x2o_Fioi_bergw,n)
! nf = f_wriof ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*x2o_o%rAttr(index_x2o_Fioi_bergw,n)
nf = f_wroff ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*x2o_o%rAttr(index_x2o_Foxx_rofl,n)
nf = f_wioff ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + (ca_o+ca_i)*x2o_o%rAttr(index_x2o_Foxx_rofi,n)

Expand Down Expand Up @@ -1652,7 +1673,8 @@ subroutine seq_diag_ice_mct( ice, frac_i, infodata, do_i2x, do_x2i)
nf = f_hsen ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + ca_i*i2x_i%rAttr(index_i2x_Faii_sen,n)
nf = f_hberg ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) - (ca_o+ca_i)*i2x_i%rAttr(index_i2x_Fioi_bergh,n)
nf = f_wmelt ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) - ca_i*i2x_i%rAttr(index_i2x_Fioi_meltw,n)
nf = f_wberg ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) - (ca_o+ca_i)*i2x_i%rAttr(index_i2x_Fioi_bergw,n)
!DC propose removing wberg from ice entry
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note I've removed the wberg calculation for ice. We don't want this term to be cancelled out by itself across ice/ocn since it's an additional forcing to the system. Rather we want to see how closely it's balanced by the removed runoff term(s).

! nf = f_wberg ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) - (ca_o+ca_i)*i2x_i%rAttr(index_i2x_Fioi_bergw,n)
nf = f_wevap ; budg_dataL(nf,ic,ip) = budg_dataL(nf,ic,ip) + ca_i*i2x_i%rAttr(index_i2x_Faii_evap,n)

if ( flds_wiso_ice )then
Expand Down
24 changes: 24 additions & 0 deletions driver-mct/shr/seq_flds_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1582,6 +1582,30 @@ subroutine seq_flds_set(nmlfile, ID, infodata)
units = 'kg m-2 s-1'
attname = 'PFioi_bergw'
call metadata_set(attname, longname, stdname, units)
!DC ismw needs P, removed runoff terms do not
! Water flux from ice shelf melt
call seq_flds_add(o2x_fluxes,"PFoxo_ismw")
longname = 'Water flux due to basal melting of ice shelves'
stdname = 'basal_iceshelf_melt_flux'
units = 'kg m-2 s-1'
attname = 'Foxo_ismw'
call metadata_set(attname, longname, stdname, units)

! Water flux from removed liquid runoff
call seq_flds_add(o2x_fluxes,"Foxo_rrofl")
longname = 'Water flux due to removed liqiud runoff'
stdname = 'removed_liquid_runoff_flux'
units = 'kg m-2 s-1'
attname = 'Foxo_rrofl'
call metadata_set(attname, longname, stdname, units)

! Water flux from removed solid runoff
call seq_flds_add(o2x_fluxes,"Foxo_rrofi")
longname = 'Water flux due to removed solid runoff'
stdname = 'removed_solid_runoff_flux'
units = 'kg m-2 s-1'
attname = 'Foxo_rrofi'
call metadata_set(attname, longname, stdname, units)

! Salt flux
call seq_flds_add(i2x_fluxes,"Fioi_salt")
Expand Down
Loading