Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable land ice frazil salinity #91

Closed
wants to merge 2 commits into from
Closed

Disable land ice frazil salinity #91

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa5393d
Remove capability to have non-zero land ice frazil salinity
cbegeman Mar 20, 2024
4811c15
Update namelist options to match Registry
cbegeman Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion components/mpas-ocean/bld/build-namelist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -759,7 +759,6 @@ add_default($nl, 'config_frazil_fractional_thickness_limit');
add_default($nl, 'config_specific_heat_sea_water');
add_default($nl, 'config_frazil_maximum_depth');
add_default($nl, 'config_frazil_sea_ice_reference_salinity');
add_default($nl, 'config_frazil_land_ice_reference_salinity');
add_default($nl, 'config_frazil_maximum_freezing_temperature');
add_default($nl, 'config_frazil_use_surface_pressure');

Expand Down
1 change: 0 additions & 1 deletion components/mpas-ocean/bld/build-namelist-section
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,6 @@ add_default($nl, 'config_frazil_fractional_thickness_limit');
add_default($nl, 'config_specific_heat_sea_water');
add_default($nl, 'config_frazil_maximum_depth');
add_default($nl, 'config_frazil_sea_ice_reference_salinity');
add_default($nl, 'config_frazil_land_ice_reference_salinity');
add_default($nl, 'config_frazil_maximum_freezing_temperature');
add_default($nl, 'config_frazil_use_surface_pressure');

Expand Down
1 change: 0 additions & 1 deletion components/mpas-ocean/bld/namelist_files/namelist_defaults_mpaso.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -380,7 +380,6 @@
<config_specific_heat_sea_water>3.996e3</config_specific_heat_sea_water>
<config_frazil_maximum_depth>100.0</config_frazil_maximum_depth>
<config_frazil_sea_ice_reference_salinity>4.0</config_frazil_sea_ice_reference_salinity>
<config_frazil_land_ice_reference_salinity>0.0</config_frazil_land_ice_reference_salinity>
<config_frazil_maximum_freezing_temperature>0.0</config_frazil_maximum_freezing_temperature>
<config_frazil_use_surface_pressure>.false.</config_frazil_use_surface_pressure>

Expand Down
10 changes: 1 addition & 9 deletions components/mpas-ocean/bld/namelist_files/namelist_definition_mpaso.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1477,20 +1477,12 @@ Default: Defined in namelist_defaults.xml

<entry id="config_frazil_sea_ice_reference_salinity" type="real"
category="frazil_ice" group="frazil_ice">
assumed salinity of frazil ice in the open ocean.
assumed salinity of frazil ice in the open ocean. Land ice frazil salinity is always 0.

Valid values: Any positive real number.
Default: Defined in namelist_defaults.xml
</entry>

<entry id="config_frazil_land_ice_reference_salinity" type="real"
category="frazil_ice" group="frazil_ice">
assumed salinity of frazil ice under land ice.

Valid values: Any non-negative real number.
Default: Defined in namelist_defaults.xml
</entry>

<entry id="config_frazil_maximum_freezing_temperature" type="real"
category="frazil_ice" group="frazil_ice">
Maximum freezing temperature for the creation of frazil
Expand Down
6 changes: 1 addition & 5 deletions components/mpas-ocean/src/Registry.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -954,13 +954,9 @@
possible_values="Any positive real number."
/>
<nml_option name="config_frazil_sea_ice_reference_salinity" type="real" default_value="4.0" units="1.e-3"
description="assumed salinity of frazil ice in the open ocean."
description="assumed salinity of frazil ice in the open ocean. Land ice frazil salinity is always 0."
possible_values="Any positive real number."
/>
<nml_option name="config_frazil_land_ice_reference_salinity" type="real" default_value="0.0" units="1.e-3"
description="assumed salinity of frazil ice under land ice."
possible_values="Any non-negative real number."
/>
<nml_option name="config_frazil_maximum_freezing_temperature" type="real" default_value="0.0" units="C"
description="Maximum freezing temperature for the creation of frazil"
possible_values="Any real number."
Expand Down
3 changes: 2 additions & 1 deletion components/mpas-ocean/src/shared/mpas_ocn_frazil_forcing.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ subroutine ocn_frazil_forcing_build_arrays(domain, meshPool, forcingPool, stateP

! get frazil salinity
if (underLandIce) then
frazilSalinity = config_frazil_land_ice_reference_salinity
frazilSalinity = 0.0_RKIND
else
frazilSalinity = config_frazil_sea_ice_reference_salinity
end if
Expand Down Expand Up @@ -622,6 +622,7 @@ subroutine ocn_frazil_forcing_build_arrays(domain, meshPool, forcingPool, stateP
! for freshwater budgets
accumulatedLandIceFrazilMassNew(iCell) = accumulatedLandIceFrazilMassOld(iCell) &
+ sumNewFrazilIceThickness * config_frazil_ice_density
! There is no accumulatedLandIceFrazilSalinity because it is always 0
end if

enddo ! do iCell = 1, nCells
Expand Down