Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set SCREAM to run with adjust_ps=.false. #4692

Closed
wants to merge 2 commits into from

Conversation

mt5555
Copy link
Contributor

@mt5555 mt5555 commented Dec 9, 2021

dont reproduce buggy behavior used in E3SM v1/v2

[BFB]
In the SCREAM model, will be non-BFB, with minor impacts on climate

This address #4693, but only for the scream code base, and thus this PR should not close #4693

dont reproduce buggy behavior used in E3SM v1/v2

[BFB]
In the SCREAM model, will be non-BFB, with minor impacts on climate
@rljacob
Copy link
Member

rljacob commented Dec 9, 2021

Is there an issue describing this bug?

@rljacob rljacob added EAMxx PRs focused on capabilities for EAMxx HOMME labels Dec 9, 2021
@oksanaguba oksanaguba self-requested a review December 9, 2021 17:44
@mt5555 mt5555 changed the title set SCREAM to run with adjust_ps=.true. set SCREAM to run with adjust_ps=.false. Dec 9, 2021
@mt5555
Copy link
Contributor Author

mt5555 commented Dec 9, 2021

@rljacob: added an issue for this PR

@mt5555
Copy link
Contributor Author

mt5555 commented Dec 9, 2021

closing this until we resolve how to best have a #ifdef SCREAM option in the E3SM Fortran code

@mt5555 mt5555 closed this Dec 9, 2021
@rljacob
Copy link
Member

rljacob commented Dec 9, 2021

What's the problem? I think the buildlib code can set the variable based on the compset long name.

@mt5555
Copy link
Contributor Author

mt5555 commented Dec 9, 2021

here a description of the issue:

E3SM-Project/scream#1343

@mt5555 mt5555 deleted the set_adjust_ps2 branch December 24, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EAMxx PRs focused on capabilities for EAMxx HOMME
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pressure update due to phase change
3 participants