Minor updates consistent with E3SM columnphysics modifications #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Short (1 sentence) summary of your PR:
Minor updates consistent with E3SM columnphysics modifications
Developer(s):
apcraig
Suggest PR reviewers from list in the column to the right.
Please copy the PR test results link or provide a summary of testing completed below.
bit-for-bit Icepack test suite on 3 compilers on cheyenne
How much do the PR code changes differ from the unmodified code?
Does this PR create or have dependencies on CICE or any other models?
Does this PR add any new test cases?
Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
Please provide any additional information or relevant details below:
Migrate hi_min to namelist+parameters and refactor implementation. In the current implementation, hi_min is set by namelist. Historically, this has been hardcoded in the model with a the value set to .01 except when kcatbound=0 and kitd/=1 where it was set to 0.1 (except if the CESMCOUPLED CPP is turned on). Users should be aware that it now needs to be set in namelist if the default value, 0.01 should be changed. In testing, when kcatbound=0 and kitd/=1, we set hi_min to 0.1 to reproduce prior results bit-for-bit and confirm this works.
Reduce CESMCOUPLED CPP use, now just for orbital stuff, punch list 23
Modify initialization of hin_max, punch list 28
Fix possible divide by zero, punch list 65
Rename icepack shr_orb_params and shr_orb_decl to icepack_orb_params, icepack_orb_decl
Cleanup argument list for compute_ponds_lvl, compute_ponds_cesm