Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Consortium #795280797a Sept 13, 2023 #29

Conversation

apcraig
Copy link
Collaborator

@apcraig apcraig commented Sep 14, 2023

PR checklist

  • Short (1 sentence) summary of your PR:
    Update to Consortium #795280797a Sept 13, 2023
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Full test suite run on cheyenne intel for icepack and cice, results are bit-for-bit except Icepack modal (expected) and CICE restart file at non-ice points (expected)
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on CICE or any other models?
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please provide any additional information or relevant details below:

Includes

  • Generalized logic for coupling frazil ice
  • Documentation updates from latest release
  • Derecho port and cheyenne port update

apcraig and others added 4 commits September 7, 2023 14:20
* Update port to Cheyenne and Derecho

All results are bit-for-bit except some pgi tests.  All machine/compiler
combinations pass all tests.

Update cheyenne gnu, intel, pgi compiler version

Minor update to Derecho intel

Add Derecho cray, gnu, intelclassic, inteloneapi, nvhpc

* Add Derecho machine files
* Update version to 1.3.4

Update License and Copyright to 2023

Update icepack interface documentation

* Update one more 2022 to 2023 copyright
* cherry-pick update_ocn_f commit: generalize update_ocn_f logic

* update interfaces.include

* declare update_ocn_f as logical

* move optional arg check and alphabetize doc
…o e3sm230830

Update to Icepack Consortium #7952807, Sept 13, 2023
@eclare108213
Copy link
Collaborator

Awesome, I'll run a quick test in E3SM.

Copy link
Collaborator

@eclare108213 eclare108213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BFB with the previous code in 3-month D cases.

@eclare108213 eclare108213 merged commit cb0d946 into E3SM-Project:cice-consortium/E3SM-icepack-initial-integration Sep 14, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants