-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default time_integrator
for Omega
#232
Conversation
This PR addresses the error found in E3SM-Project/Omega#137. |
TestingI am able to run the 200km forward run from |
@hyungyukang, would you be willing to review this fix as well? Perhaps you can test along with other testing you're doing anyway. |
Yes. I will test this PR as well! |
In the manufactured_solution test, this needs to be RungeKutte4
085316b
to
5bc4d53
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xylar , Thanks for updating this. I was able to create the manufactured solution test with Omega model (--model=omega
). In omega.yml
in the test directory, the TimeStepper
is correctly configured as RungeKutta4
.
I'm approving this PR based on my testing and @xylar 's as well as visual inspection. Thanks @xylar !
Thanks, @hyungyukang! |
In the
manufactured_solution
test, this needs to beRungeKutte4
. (I'm not worrying about other tests yet.)Checklist
Testing
comment in the PR documents testing used to verify the changes