Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance spherical tracer transport test viz #233

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

cbegeman
Copy link
Collaborator

Add options for over/under colors for the colormap used in spherical mpas visualization. These were added to be able to more conveniently visualize over and undershoots in the tracer advection scheme tested in the sphere_transport tests.

  • Testing comment in the PR documents testing used to verify the changes

@cbegeman
Copy link
Collaborator Author

Testing

The sphere transport viz step was successfully run and shows the over/under colors for the tracer field but not for the layer thickness field as expected.
tracer3_final

@cbegeman cbegeman requested a review from xylar September 30, 2024 18:22
@cbegeman cbegeman self-assigned this Sep 30, 2024
@cbegeman cbegeman added the enhancement New feature or request label Sep 30, 2024
Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great to me by visual inspection. My only suggestion would be to add it to the developer's guide if there's an appropriate place.

@xylar
Copy link
Collaborator

xylar commented Sep 30, 2024

Maybe add something to the developer's guide here:

```cfg
# options for visualization for the cosine bell convergence test case
[cosine_bell_viz]
# colormap options
# colormap
colormap_name = viridis
# the type of norm used in the colormap
norm_type = linear
# colorbar limits
colorbar_limits = 0.0, 1.0
```
`colormap_name` can be any available matplotlib colormap. For ocean test
cases, we recommend importing [cmocean](https://matplotlib.org/cmocean/) so
the standard ocean colormaps are available.
The `norm_type` is one of `linear` (a linear colormap) or `log` (a logarithmic
colormap).
The `colorbar_limits` are the lower and upper bound of the colorbar range.

And then ideally update the config options in the 4 sphere_transport test cases, e.g.:

[sphere_transport_viz_tracer]
# colormap options
# colormap
colormap_name = viridis
# the type of norm used in the colormap
norm_type = linear
# colorbar limits
colorbar_limits = 0., 1.

@cbegeman
Copy link
Collaborator Author

cbegeman commented Oct 1, 2024

@xylar Thanks for reviewing! Docs have now been updated.

@cbegeman cbegeman merged commit 002293c into E3SM-Project:main Oct 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants