Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup graph paths for cached inputs #235

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

cbegeman
Copy link
Collaborator

This PR corrects a small bug introduced by #225. When inputs are cached, we need to point to the mesh step rather than the init step for the graph files. Doesn't hurt to point to the mesh step when inputs are not cached either.

@cbegeman cbegeman self-assigned this Oct 10, 2024
@cbegeman cbegeman requested a review from xylar October 10, 2024 15:22
@cbegeman cbegeman added bug Something isn't working ocean Related to ocean tests or analysis labels Oct 10, 2024
@cbegeman
Copy link
Collaborator Author

Testing

Icos cosine bell convergence test has been tested with cached inputs on chrys with intel, impi.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that makes a lot of sense to me!

@cbegeman cbegeman merged commit 8356cef into E3SM-Project:main Oct 10, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ocean Related to ocean tests or analysis
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants