Add convergence tasks for space and time only #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestingI have tested all of the convergence tests on chrys with intel, impi. |
cbegeman
added
enhancement
cbegeman
force-pushed
the
enhance-convergence-tasks
branch
from
77312ad
to
9d40944
Compare
cbegeman
force-pushed
the
enhance-convergence-tasks
branch
from
9d40944
to
8c4d8f5
Compare
|
@sbrus89 If you want to review, feel free! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR extends the convergence test framework to accommodate convergence in space, time or both. This PR also adds additional tests for space-only and time-only convergence for the
cosine_bell,geostrophic,manufactured_solution, andinertial_gravity_wavegroups. Theconvergence_timecases have not been optimized (in terms of resolution and time steps) nor have separate convergence thresholds been specified.Checklist
api.md) has any new or modified class, method and/or functions listedTestingcomment in the PR documents testing used to verify the changes