Add flynt package to linter for updating format strings #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a draft PR because we are waiting on Flynt being added to conda-forge. @xylar and I made a merge request there, and it's waiting for review. This PR depends on those changes being accepted. |
xylar
reviewed
May 31, 2023
There was a problem hiding this comment.
Looks great! Just waiting on:
conda-forge/staged-recipes#22931
| rev: '0.78' | ||
| hooks: | ||
| - id: flynt | ||
| args: ["--fail-on-change", "--verbose"] |
There was a problem hiding this comment.
As we discussed, this is a great starting point. We'll play with these flags as we get more experience.
altheaden
added
deployment
This will convert format strings to f strings when possible
altheaden
force-pushed
the
add-flynt-to-pre-commit
branch
from
06d08d2
to
5722bae
Compare
xylar
approved these changes
Jul 5, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flynt is a package that automatically converts older-style formatting strings to f-strings. I've added this to pre-commit so that any incoming changes will use f-strings by default.
Checklist
api.md) has any new or modified class, method and/or functions listed