Skip to content

Commit

Permalink
Merge branch 'release/1.1.11' into develop
Browse files Browse the repository at this point in the history
  • Loading branch information
HI-JIN2 committed Apr 3, 2024
2 parents c9b8a4e + 5d65f7c commit b2de877
Show file tree
Hide file tree
Showing 8 changed files with 37 additions and 10 deletions.
4 changes: 2 additions & 2 deletions app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ android {
applicationId "com.eatssu.android"
minSdk 23
targetSdk 34
versionCode 12
versionName "1.1.10"
versionCode 13
versionName "1.1.11"


buildConfigField("String", "KAKAO_NATIVE_APP_KEY", "\"${properties.get('KAKAO_NATIVE_APP_KEY')}\"")
Expand Down
4 changes: 2 additions & 2 deletions app/release/output-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
"type": "SINGLE",
"filters": [],
"attributes": [],
"versionCode": 11,
"versionName": "1.1.9",
"versionCode": 13,
"versionName": "1.1.11",
"outputFile": "app-release.apk"
}
],
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ data class GetReviewListResponse(
@SerializedName("menu") var menu: String,
@SerializedName("writerId") var writerId: Long,
@SerializedName("isWriter") var isWriter: Boolean,
@SerializedName("writerNickname") var writerNickname: String,
@SerializedName("writerNickname") var writerNickname: String?,
@SerializedName("mainRating") var mainRating: Int,
@SerializedName("amountRating") var amountRating: Int,
@SerializedName("tasteRating") var tasteRating: Int,
Expand All @@ -32,7 +32,7 @@ fun GetReviewListResponse.toReviewList(): List<Review> {
reviewId = data.reviewId,
isWriter = data.isWriter,
menu = data.menu,
writerNickname = data.writerNickname,
writerNickname = data.writerNickname ?: "์œ ์ €",
mainGrade = data.mainRating,
amountGrade = data.amountRating,
tasteGrade = data.tasteRating,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ class FirebaseRemoteConfigRepository {
fun init() {
// Firebase Remote Config ์ดˆ๊ธฐํ™” ์„ค์ •
val configSettings = FirebaseRemoteConfigSettings.Builder()
.setMinimumFetchIntervalInSeconds(3600) // ์บ์‹œ๋œ ๊ฐ’์„ 1์‹œ๊ฐ„๋งˆ๋‹ค ์—…๋ฐ์ดํŠธ
.setMinimumFetchIntervalInSeconds(600) // ์บ์‹œ๋œ ๊ฐ’์„ 1์‹œ๊ฐ„๋งˆ๋‹ค ์—…๋ฐ์ดํŠธ -> 10๋ถ„
.build()
instance.setConfigSettingsAsync(configSettings)
instance.setDefaultsAsync(R.xml.firebase_remote_config)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,4 +89,10 @@ class LoginActivity :
}
}
}

override fun onBackPressed() {
super.onBackPressed()
finishAffinity()
//ํƒˆํ‡ด๋‚˜ ๋กœ๊ทธ์•„์›ƒ ํ•˜๊ณ  ๋กœ๊ทธ์ธ ํ™”๋ฉด์œผ๋กœ ์˜ค๊ณ , ๊ทธ ๋’ค์— ๋’ค๋กœ ๊ฐ€๊ธฐ๋ฅผ ๋ˆŒ๋ €์„ ๋•Œ์— ๋ฐฑ์Šคํƒ ๋ฐฉ์ง€
}
}
2 changes: 2 additions & 0 deletions app/src/main/java/com/eatssu/android/ui/main/MainActivity.kt
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,8 @@ class MainActivity : BaseActivity<ActivityMainBinding>(ActivityMainBinding::infl
lifecycleScope.launch {
mainViewModel.uiState.collectLatest {
if (it.isNicknameNull) {
//๋‹‰๋„ค์ž„์ด null์ผ ๋•Œ๋Š” ๋‹‰๋„ค์ž„ ์„ค์ •์„ ์•ˆํ•˜๋ฉด ์„œ๋น„์Šค๋ฅผ ๋ชป์“ฐ๊ฒŒ ๋ง‰์•„์•ผํ•จ
intent.putExtra("force", true)
startActivity<UserNameChangeActivity>()
showToast(it.toastMessage)
} else {
Expand Down
6 changes: 3 additions & 3 deletions app/src/main/java/com/eatssu/android/ui/main/MainViewModel.kt
Original file line number Diff line number Diff line change
Expand Up @@ -26,9 +26,9 @@ class MainViewModel @Inject constructor(
private val _uiState: MutableStateFlow<MainState> = MutableStateFlow(MainState())
val uiState: StateFlow<MainState> = _uiState.asStateFlow()

init {
checkNameNull()
}
// init {
// checkNameNull()
// } ์–˜ ๋–„๋ฌธ์— ๋‘๋ฒˆ์”ฉ ์ฒ˜๋ฆฌ๋จ.

fun checkNameNull() {
viewModelScope.launch {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,18 @@ class UserNameChangeActivity : BaseActivity<ActivityUserNameChangeBinding>(Activ

private var inputNickname: String = ""

private var force: Boolean = false


override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
toolbarTitle.text = "๋‹‰๋„ค์ž„ ์„ค์ •" // ํˆด๋ฐ” ์ œ๋ชฉ ์„ค์ •


force = intent.getBooleanExtra("force", false)
//Todo null ์ผ๋•Œ ํ•œ์ •์œผ๋กœ ํ™”๋ฉด์—์„œ ๋ชป ๋ฒ—์–ด๋‚˜๊ฒŒ ๊ธฐ๋Šฅ ์ถ”๊ฐ€


binding.btnCheckNickname.isEnabled = false
binding.btnComplete.isEnabled = false

Expand All @@ -46,6 +54,17 @@ class UserNameChangeActivity : BaseActivity<ActivityUserNameChangeBinding>(Activ
setOnClickListener()
}

// override fun onBackPressed() {
// if (force) {
// // force๊ฐ€ true์ผ ๋•Œ๋Š” ๋’ค๋กœ๊ฐ€๊ธฐ ๋ฒ„ํŠผ์„ ๋ฌด์‹œํ•˜๊ณ  ํ˜„์žฌ ํ™”๋ฉด์— ๋จธ๋ฌผ๊ฒŒ ํ•จ
// // ์—ฌ๊ธฐ์— ๋‹ค๋ฅธ ๋™์ž‘์„ ์ถ”๊ฐ€ํ•  ์ˆ˜๋„ ์žˆ์Œ
// showToast("๋‹‰๋„ค์ž„ ์„ค์ • ํ›„, ์„œ๋น„์Šค๋ฅผ ์ด์šฉํ•˜์‹ค ์ˆ˜ ์žˆ์Šต๋‹ˆ๋‹ค.")
// } else {
// // force๊ฐ€ false์ผ ๋•Œ๋Š” ๊ธฐ๋ณธ ๋’ค๋กœ๊ฐ€๊ธฐ ๋™์ž‘์„ ์ˆ˜ํ–‰
// super.onBackPressed()
// }
// }

private fun setOnClickListener() {
binding.btnCheckNickname.setOnClickListener {
userNameChangeViewModel.checkNickname(inputNickname)
Expand Down

0 comments on commit b2de877

Please sign in to comment.