Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create data documentation md file #13

Merged
merged 6 commits into from
Jun 8, 2020
Merged

Create data documentation md file #13

merged 6 commits into from
Jun 8, 2020

Conversation

joj0s
Copy link
Collaborator

@joj0s joj0s commented Jun 4, 2020

This PR contains a markdown file containing documentation for the data model as well as the trait status transitions, along with a mermaid diagram and its source code. Closes #7 , closes #8

A consideration I have is that the table describing the trait statuses is very big and therefore the markdown required to output it is quite not user-friendly, so we might want to change the way we show that piece of information.

I also uploaded the png diagram to Imgur so that is stays permanently and that the link is small

@joj0s joj0s requested a review from tskir June 4, 2020 09:38
Copy link
Member

@tskir tskir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good documentation, just some notes about formatting.

Regarding Markdown table and the diagram PNG, I've addressed that in separate comments

docs/data-model.md Outdated Show resolved Hide resolved
docs/data-model.md Outdated Show resolved Hide resolved
docs/data-model.md Outdated Show resolved Hide resolved
docs/data-model.md Outdated Show resolved Hide resolved
@joj0s joj0s requested a review from tskir June 7, 2020 11:56
@tskir
Copy link
Member

tskir commented Jun 8, 2020

Great, all comments addressed without further issues, merging this

@tskir tskir merged commit 033f4c5 into master Jun 8, 2020
@tskir tskir deleted the data_docs branch June 8, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants