Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

すべての依存パッケージを composer.json に記載 #2807

Merged
merged 4 commits into from
Feb 2, 2018

Conversation

nanasess
Copy link
Contributor

概要(Overview・Refs Issue)

  • すべての依存パッケージを composer.json に記載
  • Flex による .gitignore の修正

実装に関する補足(Appendix)

以下のコマンドを実行し、 composer.json を修正

composer show | awk '{print $1}' | xargs composer require --no-scripts

あとは、適宜 require-dev を調整

テスト(Test)

  • ユニットテストが通るのを確認

その他

symfony/polyfill-php56 は、 不要と思われるが、 symfony/security の依存関係で入っている

@chihiro-adachi chihiro-adachi added this to the 3.n.0 milestone Jan 30, 2018
@nanasess nanasess changed the title すべての依存パッケージを composer.json に記載 [WIP]すべての依存パッケージを composer.json に記載 Jan 30, 2018
@nanasess
Copy link
Contributor Author

nanasess commented Jan 30, 2018

Symfony 3.4.4 にメモリリークのバグがありそうなので、 WIP にしておきます。
symfony/debug 3.4.4 を conflict に追加しました

@nanasess nanasess changed the title [WIP]すべての依存パッケージを composer.json に記載 すべての依存パッケージを composer.json に記載 Jan 31, 2018
@chihiro-adachi chihiro-adachi merged commit 8cfdf06 into EC-CUBE:experimental/sf Feb 2, 2018
@nanasess nanasess deleted the update-composer branch February 13, 2018 05:21
@okazy okazy mentioned this pull request Apr 12, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants