Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Symfony4.4 対応 #4409

Merged
merged 25 commits into from
Jun 26, 2020
Merged

Symfony4.4 対応 #4409

merged 25 commits into from
Jun 26, 2020

Conversation

nanasess
Copy link
Contributor

概要(Overview・Refs Issue)

  • Symfony4.4 の検証

方針(Policy)

  • Symfony4.4 でユニットテスト、 E2Eテストが通る状態とする

実装に関する補足(Appendix)

テスト（Test)

相談（Discussion）

マイナーバージョン互換性保持のための制限事項チェックリスト

  • 既存機能の仕様変更
  • フックポイントの呼び出しタイミングの変更
  • フックポイントのパラメータの削除・データ型の変更
  • twigファイルに渡しているパラメータの削除・データ型の変更
  • Serviceクラスの公開関数の、引数の削除・データ型の変更
  • 入出力ファイル(CSVなど)のフォーマット変更

レビュワー確認項目

  • 動作確認
  • コードレビュー
  • E2E/Unit テスト確認(テストの追加・変更が必要かどうか)
  • 互換性が保持されているか
  • セキュリティ上の問題がないか

@chihiro-adachi chihiro-adachi added this to the 4.0.x milestone Dec 23, 2019
@chihiro-adachi chihiro-adachi added the enhancement 機能追加 label Dec 26, 2019
@nanasess nanasess mentioned this pull request May 1, 2020
Closed
16 tasks
@chihiro-adachi
Copy link
Contributor

@nanasess
symfony4.4への移行について、現時点でわかっている影響範囲をまとめてみました。
過不足あればご指摘いただければと。
EC-CUBE/doc4.ec-cube.net#87

@nanasess
Copy link
Contributor Author

Doctrine Bundle のキャッシュまわりに変更が入っているようなので、この設定で問題ないか確認しておいた方がよさそう
https://github.com/EC-CUBE/ec-cube/pull/4396/files#diff-ecfe1e5b0fe4674aa7c5218bee27315b

@chihiro-adachi chihiro-adachi changed the base branch from 4.0 to experimental/symfony44 June 23, 2020 06:07
@nanasess @chihiro-adachi
非推奨の警告を表示
3eee579
@nanasess @chihiro-adachi
softDeleteFilter は使用しなくなったため削除
0d39cea 
- The Eccube\Util\EntityUtil::isEmpty method is deprecated.
@nanasess @chihiro-adachi
Fix deprecated Symfony Container
7805a62 
- The "Eccube\Repository\*Repository" service is private, getting it from the container is deprecated since Symfony 3.2 and will fail in 4.0. You should either make the service public, or stop using the container directly and use dependency injection instead.
@nanasess @chihiro-adachi
Symfony4.4 support
89871d2
@nanasess @chihiro-adachi
container 変数を static に変更
14cd3fb 
see https://symfony.com/blog/new-in-symfony-4-1-simpler-service-testing
@nanasess @chihiro-adachi
プレースホルダを使用しているメッセージ '' で囲む
d2a3d8d
@nanasess @chihiro-adachi
Fix variables
ebaa18c
@nanasess @chihiro-adachi
Set scope to public
ccb40a1
@nanasess @chihiro-adachi
Use Interface
53ec7ce
@nanasess @chihiro-adachi
Fix variables
656449c
@nanasess @chihiro-adachi
Add getExtendedTypes()
2fc9ff9
@nanasess @chihiro-adachi
Add FIXME comment
a1cbf96
@nanasess @chihiro-adachi
Use static
a184233
@nanasess @chihiro-adachi
Fixes EC-CUBE#2874 Serializable を実装
0824c7e 
- Symfony/Cache が Closure を使用している関係で Serializable を実装しないとログインに失敗するため
@nanasess @chihiro-adachi
form.type_extension は autoconfiguration の対象になったため削除
5b6d239
@nanasess @chihiro-adachi
Revert to FormExtension
91f541b
@nanasess @chihiro-adachi
Fix obsolete class name
9e458ab
@nanasess @chihiro-adachi
Remove obsolete to Silex Application
c2605b6
@nanasess @chihiro-adachi
ComposerApiService to public
7c5262a
@nanasess @chihiro-adachi
Fix functions to logger and translation
4060178
@nanasess @chihiro-adachi
AnnotationReader を Facade で設定するように修正
e9f0ab6 
- LoadEventSubscriber は廃止
@nanasess @chihiro-adachi
Customer の Serializable 実装に伴う修正
9a84daf 
- 配列でセッションに保存し, オブジェクトに復元するよう修正
- OrderHelper::getNonMember() でセッションキーを指定できるよう修正
@nanasess @chihiro-adachi
Add Form::isSubmitted()
bf97f13
@nanasess @chihiro-adachi
TODO エラーメッセージが翻訳されない
25ba288
@nanasess @chihiro-adachi
Apply composer update
b710b1f 
- Updating doctrine/cache (1.9.1 => 1.10.0)
- Updating doctrine/doctrine-cache-bundle (1.3.5 => 1.4.0)
- Updating guzzlehttp/guzzle (6.4.1 => 6.5.0)
- Updating symfony/asset (v4.4.0 => v4.4.1)
- Updating symfony/browser-kit (v4.4.0 => v4.4.1)
- Updating symfony/cache (v4.4.0 => v4.4.1)
- Updating symfony/config (v4.4.0 => v4.4.1)
- Updating symfony/console (v4.4.0 => v4.4.1)
- Updating symfony/css-selector (v4.4.0 => v4.4.1)
- Updating symfony/debug (v4.4.0 => v4.4.1)
- Updating symfony/debug-bundle (v4.4.0 => v4.4.1)
- Updating symfony/dependency-injection (v4.4.0 => v4.4.1)
- Updating symfony/doctrine-bridge (v4.4.0 => v4.4.1)
- Updating symfony/dom-crawler (v4.4.0 => v4.4.1)
- Updating symfony/dotenv (v4.4.0 => v4.4.1)
- Updating symfony/error-handler (v4.4.0 => v4.4.1)
- Updating symfony/event-dispatcher (v4.4.0 => v4.4.1)
- Updating symfony/expression-language (v4.4.0 => v4.4.1)
- Updating symfony/filesystem (v4.4.0 => v4.4.1)
- Updating symfony/finder (v4.4.0 => v4.4.1)
- Updating symfony/flex (v1.4.8 => v1.5.3)
- Updating symfony/form (v4.4.0 => v4.4.1)
- Updating symfony/framework-bundle (v4.4.0 => v4.4.1)
- Updating symfony/http-foundation (v4.4.0 => v4.4.1)
- Updating symfony/http-kernel (v4.4.0 => v4.4.1)
- Updating symfony/inflector (v4.4.0 => v4.4.1)
- Updating symfony/intl (v4.4.0 => v4.4.1)
- Updating symfony/mime (v4.4.0 => v4.4.1)
- Updating symfony/monolog-bridge (v4.4.0 => v4.4.1)
- Updating symfony/options-resolver (v4.4.0 => v4.4.1)
- Updating symfony/phpunit-bridge (v4.4.0 => v4.4.1)
- Updating symfony/polyfill-ctype (v1.13.0 => v1.13.1)
- Updating symfony/polyfill-iconv (v1.13.0 => v1.13.1)
- Updating symfony/polyfill-intl-icu (v1.13.0 => v1.13.1)
- Updating symfony/polyfill-intl-idn (v1.13.0 => v1.13.1)
- Updating symfony/polyfill-mbstring (v1.13.0 => v1.13.1)
- Updating symfony/polyfill-php70 (v1.13.0 => v1.13.1)
- Updating symfony/polyfill-php72 (v1.13.0 => v1.13.1)
- Updating symfony/polyfill-php73 (v1.13.0 => v1.13.1)
- Updating symfony/process (v4.4.0 => v4.4.1)
- Updating symfony/property-access (v4.4.0 => v4.4.1)
- Updating symfony/proxy-manager-bridge (v4.4.0 => v4.4.1)
- Updating symfony/routing (v4.4.0 => v4.4.1)
- Updating symfony/security (v4.4.0 => v4.4.1)
- Updating symfony/security-bundle (v4.4.0 => v4.4.1)
- Updating symfony/serializer (v4.4.0 => v4.4.1)
- Updating symfony/stopwatch (v4.4.0 => v4.4.1)
- Updating symfony/templating (v4.4.0 => v4.4.1)
- Updating symfony/translation (v4.4.0 => v4.4.1)
- Updating symfony/twig-bridge (v4.4.0 => v4.4.1)
- Updating symfony/twig-bundle (v4.4.0 => v4.4.1)
- Updating symfony/validator (v4.4.0 => v4.4.1)
- Updating symfony/var-dumper (v4.4.0 => v4.4.1)
- Updating symfony/var-exporter (v4.4.0 => v4.4.1)
- Updating symfony/web-profiler-bundle (v4.4.0 => v4.4.1)
- Updating symfony/web-server-bundle (v4.4.0 => v4.4.1)
- Updating symfony/workflow (v4.4.0 => v4.4.1)
- Updating symfony/yaml (v4.4.0 => v4.4.1)
- Updating zendframework/zend-code (3.4.0 => 3.4.1)
@chihiro-adachi chihiro-adachi changed the base branch from experimental/symfony44 to experimental/symfony4.4 June 26, 2020 06:43
@chihiro-adachi chihiro-adachi modified the milestones: 4.0.x, 4.1 Jun 26, 2020
@chihiro-adachi
Copy link
Contributor

experimental/symfony4.4ブランチにマージします。
https://github.com/EC-CUBE/ec-cube/tree/experimental/symfony4.4

@chihiro-adachi chihiro-adachi merged commit bcc3f25 into EC-CUBE:experimental/symfony4.4 Jun 26, 2020
@chihiro-adachi chihiro-adachi mentioned this pull request Jun 26, 2020
Merged
11 tasks
@okazy okazy mentioned this pull request Jun 30, 2020
Open
This was referenced Nov 2, 2020
Closed
Closed
@okazy okazy changed the title [WIP] Symfony4.4 対応 Symfony4.4 対応 Dec 9, 2020
@nanasess nanasess deleted the improve/symfony4.4 branch October 3, 2022 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement 機能追加
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nanasess @chihiro-adachi