Googleアナリティクスのトラッキング設定機能追加 #5029
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nanasess
requested changes
Nov 26, 2021
| @@ -13,3 +13,4 @@ | |||
| "12","10","新着情報","news","2017-03-07 10:14:52","2017-03-07 10:14:52","0","0","block" | |||
| "13","10","商品検索","search_product","2017-03-07 10:14:52","2017-03-07 10:14:52","1","0","block" | |||
| "14","10","トピック","topic","2017-03-07 10:14:52","2017-03-07 10:14:52","0","0","block" | |||
| "15","10","トラッキングコード","tracking_code","2021-05-05 00:00:00","2021-05-05 00:00:00","block" | |||
There was a problem hiding this comment.
Suggested change
| "15","10","トラッキングコード","tracking_code","2021-05-05 00:00:00","2021-05-05 00:00:00","block" | |
| "15","10","トラッキングコード","tracking_code","2021-05-05 00:00:00","2021-05-05 00:00:00","0","0","block" |
カラムが不足しているようですのでご確認お願いします
| @@ -13,3 +13,4 @@ id,device_type_id,block_name,file_name,create_date,update_date,use_controller,de | |||
| 12,10,News,news,2017-03-07 10:14:52,2017-03-07 10:14:52,0,0,block | |||
| 13,10,Product Search,search_product,2017-03-07 10:14:52,2017-03-07 10:14:52,1,0,block | |||
| 14,10,Featured,topic,2017-03-07 10:14:52,2017-03-07 10:14:52,0,0,block | |||
| "15","10","Tracking Code","tracking_code","2021-05-05 00:00:00","2021-05-05 00:00:00","block" | |||
There was a problem hiding this comment.
Suggested change
| "15","10","Tracking Code","tracking_code","2021-05-05 00:00:00","2021-05-05 00:00:00","block" | |
| "15","10","Tracking Code","tracking_code","2021-05-05 00:00:00","2021-05-05 00:00:00","0","0","block" |
カラムが不足しているようですのでご確認お願いします
|
この実装ですが、ブロック管理からtracking_code.twigの内容を登録すれば要件は満たされると思いますので、 3系ではドキュメントとしてありました。 |
|
追記ですがこの機能を実装されるなら、 |
|
@refine-kenshi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要(Overview・Refs Issue)
GA4への対応が将来的に必要となるが、GAを実装しない実装はほぼ存在しない。
マーケティング部隊がいる場合は、グーグルタグマネージャーを実装することが多いがeccube co の一般的なことを考慮すると標準であっても問題ない。
方針(Policy)
###管理画面：トラッキングIDの登録
・dtb_base_infoへ「tracking_id」追加
・設定>店舗設定>基本設定へ「tracking_id」フィールド追加
・コンテンツ管理>ブロック管理へ「tracking_code.twig」追加
###フロント画面：トラッキングIDの読込み
・tracking_code.twigを作成
・default_frame.twigへ「BaseInf.tracking_id」あれば「tracking_code.twig」読込み
テスト（Test)
・管理画面：設定>店舗設定>基本設定でtracking_idの「登録・更新」
・フロント画面：「BaseInf.tracking_id」ありなしで「tracking_code.twig」読込み確認
相談（Discussion）
tracking_idのバリデーションについて
・現在MAX255のみにしている
MAX値は減らした方が良い？その場合の適正値は？
数字＋ハイフンも入れた方が良いか？
マイナーバージョン互換性保持のための制限事項チェックリスト
レビュワー確認項目